Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using bitwise operators with Booleans #214

Merged
merged 2 commits into from
Oct 27, 2023
Merged

Stop using bitwise operators with Booleans #214

merged 2 commits into from
Oct 27, 2023

Conversation

paolafer
Copy link
Contributor

This PR fixes the use of bitwise operators with booleans. Although in nexus the behaviour was the expected one, it could be misleading, and it raised compilation warnings.

@paolafer paolafer requested a review from atrettin October 17, 2023 12:26
atrettin
atrettin approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@atrettin atrettin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks straight forward enough! Yes, && should always be used when combining logical expressions to ensure correct short-circuiting behavior, although these expressions look like it wouldn't make a lot of difference. I approve these changes.

@paolafer paolafer merged commit 5389016 into next-exp:master Oct 27, 2023
1 check passed
@paolafer paolafer deleted the silence-warning branch October 27, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atrettin atrettin atrettin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paolafer @atrettin