Use dielectric grids for automatic overlap checks #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gonzaponte
reviewed
Apr 19, 2024
paolafer
force-pushed
the
fix-overlap-check
branch
from
d383012 to
2397604
Compare
paolafer
force-pushed
the
fix-overlap-check
branch
2 times, most recently
from
da85b38 to
b28089d
Compare
paolafer
force-pushed
the
fix-overlap-check
branch
from
b28089d to
10b7cec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The automatic tests that perform the overlap checks were taking ages to be executed, since the implementation of stainless steel grids as the default option in NEXT-100. This PR replaces the macros used for the overlap checks with others that use dielectric grids (the other option).