Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perf: do not need merge theme_config #121

Closed
wants to merge 1 commit into from
Closed

Perf: do not need merge theme_config #121

wants to merge 1 commit into from

Conversation

YunYouJun
Copy link

PR Checklist

  • The commit message follows guidelines for NexT.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for features).

PR Type

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Documentation.
  • Translation.
  • Other... Please describe:

What is the current behavior?

Do not need merge theme_config, because hexo has merged it.

https://github.com/hexojs/hexo/blob/9b41e6d30bef0418d312e783c9bba6d290c1e4fb/lib/hexo/index.js#L41

@welcome
Copy link

welcome bot commented Oct 7, 2020

Thanks so much for opening your first PR here!

@CLAassistant
Copy link

CLAassistant commented Oct 7, 2020

CLA assistant check
All committers have signed the CLA.

@stevenjoezhang
Copy link
Member

See also hexojs/hexo#4360 (comment) . This is the "additional code"
Deleting it will cause bugs with Hexo 4, but Hexo 5 will not be affected

@YunYouJun
Copy link
Author

I see. 🤣 So this is a compatible baggage.

@stevenjoezhang
Copy link
Member

stevenjoezhang commented Oct 7, 2020

I will apply this patch after NexT drops Hexo 4 support. Thanks for your contribution!

Update: 817ef09

See also theme-next/hexo-theme-next#1430

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants