Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve code related to OAuth section #11954

Merged
merged 4 commits into from
Dec 3, 2024

Conversation

halvaradop
Copy link
Contributor

@halvaradop halvaradop commented Oct 2, 2024

☕️ Reasoning

This pull request refines the codebase related to the OAuth section to reduce redundancy and enhance flexibility. The changes focus on providing a more generalized structure, making it easier to implement new features like a search bar or adapt current code with minimal changes:

  • Removed the useOAuthProviderSelect hook
  • Cleaned up the OAuthProviderInstructions component
  • Introduced the new PreviewProviders component
  • Added the useSelectCombobox hook
  • Created a hooks folder and update the tsconfig.json paths

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

📌 Resources

- Removed the `useOAuthProviderSelect` hook
- Cleaned up the `OAuthProviderInstructions` component
- Introduced the new `PreviewProviders` component
- Added the `useSelectCombobox` hook
- Created a `hooks` folder and update the `tsconfig.json` paths
Copy link

vercel bot commented Oct 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 30, 2024 8:17pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview Nov 30, 2024 8:17pm

Copy link

vercel bot commented Oct 2, 2024

@halvaradop is attempting to deploy a commit to the authjs Team on Vercel.

A member of the Team first needs to authorize it.

- Replace `getHighlighter` with `createHighlighter`
- Ensure compatibility with existing functionality
Copy link
Member

@ndom91 ndom91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This just popped up on my radar again, looks good. Thanks!

@ndom91 ndom91 merged commit 00b16ae into nextauthjs:main Dec 3, 2024
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants