Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): vendor cookie until it has an ESM build #12248

Merged
merged 2 commits into from
Nov 16, 2024
Merged

Conversation

balazsorban44
Copy link
Member

☕️ Reasoning

jshttp/cookie#211

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

📌 Resources

Copy link

vercel bot commented Nov 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 16, 2024 8:29am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview Nov 16, 2024 8:29am
proxy ⬜️ Ignored (Inspect) Visit Preview Nov 16, 2024 8:29am

@github-actions github-actions bot added the core Refers to `@auth/core` label Nov 16, 2024
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@eslint/compat@1.1.1 None 0 47.7 kB eslintbot
npm/@eslint/js@9.9.1 None 0 14.2 kB eslintbot
npm/@graphql-codegen/cli@5.0.0 environment, filesystem, network, shell, unsafe +52 10.1 MB dotansimha
npm/@graphql-codegen/client-preset@4.1.0 Transitive: environment, eval, filesystem, shell, unsafe +40 11.8 MB dotansimha
npm/@graphql-typed-document-node/core@3.2.0 None 0 2.96 kB dotansimha
npm/@inkeep/widgets@0.2.289 Transitive: environment, filesystem, network, shell, unsafe +28 22.2 MB sarah-inkeep
npm/@mikro-orm/core@5.9.7 environment, eval, filesystem, unsafe 0 888 kB b4nan
npm/@mikro-orm/sqlite@5.9.7 filesystem +1 354 kB b4nan
npm/@miniflare/d1@2.14.2 filesystem, unsafe Transitive: environment, eval, network, shell +5 460 kB wrangler-publisher
npm/@next/third-parties@14.2.15 None 0 14.2 kB vercel-release-bot
npm/@playwright/test@1.40.0 None 0 25.3 kB dgozman-ms
npm/@preact/preset-vite@2.8.1 Transitive: environment, filesystem, unsafe +35 7.99 MB rschristian
npm/@prettier/plugin-pug@3.0.0 environment 0 349 kB shinigami92
npm/@prisma/client@5.20.0 environment, filesystem, shell 0 9.16 MB prismabot
npm/@prisma/extension-accelerate@1.1.0 None 0 62.8 kB prismabot
npm/@radix-ui/react-accordion@1.2.1 None +13 321 kB chancestrickland
npm/@radix-ui/react-tabs@1.1.1 None +13 303 kB chancestrickland
npm/@simplewebauthn/browser@9.0.1 None 0 42 kB iamkale
npm/vite@5.3.1 environment, eval, filesystem, network, shell, unsafe 0 3.26 MB vitebot

🚮 Removed packages: npm/@auth/express@0.8.3, npm/@auth/unstorage-adapter@2.7.3, npm/@radix-ui/react-avatar@1.1.1, npm/@radix-ui/react-dropdown-menu@2.1.2, npm/@radix-ui/react-navigation-menu@1.2.1, npm/@types/express@4.17.21, npm/@types/morgan@1.9.9, npm/@types/react-dom@18.3.1, npm/@types/react@18.3.12, npm/@vercel/kv@1.0.1, npm/autoprefixer@10.4.20, npm/class-variance-authority@0.7.0, npm/clsx@2.1.1, npm/express@4.21.1, npm/lucide-react@0.274.0, npm/morgan@1.10.0, npm/next-auth@5.0.0-beta.25, npm/next@15.0.3, npm/pug@3.0.3, npm/react-dom@18.3.1, npm/react@18.3.1, npm/tailwind-merge@1.14.0, npm/tailwindcss-animate@1.0.7, npm/tailwindcss@3.4.15, npm/tsx@4.19.2, npm/unstorage@1.13.1

View full report↗︎

@balazsorban44 balazsorban44 merged commit a150f1e into main Nov 16, 2024
9 of 11 checks passed
@balazsorban44 balazsorban44 deleted the fix/esm-cookie branch November 16, 2024 08:21
Copy link

codecov bot commented Nov 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.09%. Comparing base (4b01b46) to head (dd82d3b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main   #12248       +/-   ##
===========================================
+ Coverage   39.15%   62.09%   +22.93%     
===========================================
  Files         191      127       -64     
  Lines       29988     6054    -23934     
  Branches     1291      434      -857     
===========================================
- Hits        11742     3759     -7983     
+ Misses      18246     2295    -15951     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Refers to `@auth/core`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant