Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(drizzle): fix typo verfication to verification #12376

Merged
merged 1 commit into from
Dec 22, 2024

Conversation

nrjdalal
Copy link
Contributor

@nrjdalal nrjdalal commented Dec 13, 2024

☕️ Reasoning

Instead of referencing docs, I reference schema from here, saw a typo and corrected it, it won't affect the performance or the adapter in anyway, just fixing human error.

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

📌 Resources

@nrjdalal nrjdalal requested a review from ndom91 as a code owner December 13, 2024 02:43
Copy link

vercel bot commented Dec 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ❌ Failed (Inspect) Dec 22, 2024 1:43am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview Dec 22, 2024 1:43am

Copy link

vercel bot commented Dec 13, 2024

@nrjdalal is attempting to deploy a commit to the authjs Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added adapters Changes related to the core code concerning database adapters drizzle @auth/drizzle-adapter labels Dec 13, 2024
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 39.52%. Comparing base (7969dd5) to head (1355093).

Files with missing lines Patch % Lines
packages/adapter-drizzle/src/lib/pg.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12376   +/-   ##
=======================================
  Coverage   39.52%   39.52%           
=======================================
  Files         193      193           
  Lines       30552    30552           
  Branches     1338     1338           
=======================================
  Hits        12077    12077           
  Misses      18475    18475           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nrjdalal nrjdalal changed the title refactor: fixing typo verfication to verification and updating docs refactor: fixing typo verfication to verification Dec 13, 2024
Copy link
Contributor Author

@nrjdalal nrjdalal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It won't affect the performance or the adapter in anyway, just fixing human error. No need for tests.

Copy link
Member

@ndom91 ndom91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@ndom91 ndom91 changed the title refactor: fixing typo verfication to verification chore(drizzle): fix typo verfication to verification Dec 22, 2024
@ndom91 ndom91 merged commit c986a0d into nextauthjs:main Dec 22, 2024
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adapters Changes related to the core code concerning database adapters drizzle @auth/drizzle-adapter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants