fix(oauth): correctly remove code_verifier cookie when used
#2325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nextauthjs/next-auth/FUepxM5cSfTStySRwPg2Qco3SbMQ |
Codecov Report
@@ Coverage Diff @@
## main #2325 +/- ##
=====================================
Coverage 9.96% 9.96%
=====================================
Files 82 82
Lines 1395 1395
Branches 395 395
=====================================
Hits 139 139
Misses 1030 1030
Partials 226 226
Continue to review full report at Codecov.
|
|
Appreciate this PR, good catch! I'll try this out and merge if all is well! 🙏 |
balazsorban44
changed the title
code_verifier cookie when used
mnphpexpert
added a commit
to mnphpexpert/next-auth
that referenced
this pull request
Sep 2, 2024
…thjs#2325) Co-authored-by: Pol Bonastre <pbonastre@plainconcepts.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning 💡
Once the pkce code verifier is used, the cookie is cleared but the browser blocks the deletion of this cookie, keeping it in the browser until it expires.
This is because when using the cookie with the useSecureCookies option enabled (https environment), the cookie is prefixed with __Secure-. and it must use the
cookies.pkceCodeVerifier.optionsoptions to be valid (the secure attribute must be set to true).Checklist 🧢
Affected issues 🎟