Don't transform all modules to commonjs #23
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enforcing modules transformation to commonjs does block webpack from using code splitting.
From https://babeljs.io/docs/en/babel-preset-env:
Encountered in nextcloud/text#1659 where the dynamic imports with a
/* webpackChunkName */
comment no longer created chunks with the shared configs, when testing i also noticed that this is the case for the contacts app where the moment chunks are no longer built.@skjnldsv Was there any specific reason this was explicitly set to commonjs?