tests/ci: Use cypress tests for code coverage #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ructure Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
feat/cypress-code-coverage
branch
from
4965f5c
to
233321f
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #265 +/- ##
===========================================
+ Coverage 0 95.94% +95.94%
===========================================
Files 0 5 +5
Lines 0 74 +74
Branches 0 1 +1
===========================================
+ Hits 0 71 +71
- Misses 0 3 +3 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
feat/cypress-code-coverage
branch
from
233321f
to
361ea0d
Compare
skjnldsv
reviewed
Jul 6, 2023
|
I think as this projects provides cypress commands we need to use cypress to test it and so we can use the coverage data from that tests (e2e tests in this project are basically unit tests for our commands). |
|
Yeah, make sense! It's kind of a very specific use case :) |
skjnldsv
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to instrument code for code coverage tests and save results to codecov.