Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not rollup types #1142

Merged
merged 1 commit into from
Dec 11, 2024
Merged

fix: Do not rollup types #1142

merged 1 commit into from
Dec 11, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Dec 11, 2024

The rollup only works for single entry point and will duplicate
declarations.
See: https://api-extractor.com/pages/setup/configure_rollup/#an-important-limitation

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added bug Something isn't working 3. to review labels Dec 11, 2024
Copy link

codecov bot commented Dec 11, 2024

Bundle Report

Changes will increase total bundle size by 1.92kB (0.39%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
@nextcloud/files-esm 122.84kB 1.92kB (1.58%) ⬆️

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.62%. Comparing base (f1d1a84) to head (31de6e0).
Report is 28 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1142   +/-   ##
=======================================
  Coverage   91.62%   91.62%           
=======================================
  Files          23       23           
  Lines         633      633           
  Branches      166      166           
=======================================
  Hits          580      580           
  Misses         46       46           
  Partials        7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skjnldsv skjnldsv merged commit af6640e into main Dec 11, 2024
18 checks passed
@skjnldsv skjnldsv deleted the fix/do-not-rollup branch December 11, 2024 22:07
@skjnldsv skjnldsv mentioned this pull request Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redeclaration of Node_2 class causes type incompatibilty
2 participants