fix: Remove unreachable code

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
nextcloud-libraries · Jan 29, 2024 · d55dbc6 · d55dbc6
1 parent 3f8327e
commit d55dbc6
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/lib/index.ts b/lib/index.ts
@@ -163,16 +163,17 @@ export const imagePath = (app: string, file: string) => {
  */
 export const generateFilePath = (app: string, type: string, file: string) => {
 	const isCore = window?.OC?.coreApps?.indexOf(app) !== -1
+	const isPHP = file.slice(-3) === 'php'
 	let link = getRootUrl()
-	if (file.substring(file.length - 3) === 'php' && !isCore) {
+	if (isPHP && !isCore) {
 		link += `/index.php/apps/${app}`
 		if (type) {
 			link += `/${encodeURI(type)}`
 		}
 		if (file !== 'index.php') {
 			link += `/${file}`
 		}
-	} else if (file.substring(file.length - 3) !== 'php' && !isCore) {
+	} else if (!isPHP && !isCore) {
 		link = getAppRootUrl(app)
 		if (type) {
 			link += '/' + type + '/'
@@ -187,9 +188,6 @@ export const generateFilePath = (app: string, type: string, file: string) => {
 		} else {
 			link += '/'
 		}
-		if (!isCore) {
-			link += 'apps/'
-		}
 		if (app !== '') {
 			app += '/'
 			link += app