Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop core-js and move to vite #563

Merged
merged 3 commits into from
Jan 24, 2024
Merged

Drop core-js and move to vite #563

merged 3 commits into from
Jan 24, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jan 24, 2024

  • Move from babel to Vite for bundling and use our config to be consistent
  • Drop core-js as a dependency, it is automatically included and loaded by server core.

¹: `core-js` is now automatically loaded by Nextcloud server so no need for bundling

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Copy link

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't checked what we do in other libs, but this migration brings one change - dist is now minimized.

I'm not sure it is needed because:

  • The final build of app/library is handled by their bundling anyway, minimizing library dist doesn't have any advantages
  • It makes debug of apps/libs more complicated, because even in dev build of app/lib, this dependency is minimized

Other than that, everything is fine

package.json Outdated Show resolved Hide resolved
@susnux
Copy link
Contributor Author

susnux commented Jan 24, 2024

I haven't checked what we do in other libs, but this migration brings one change - dist is now minimized.

We do it everywhere as well. Maybe adjust at @nextcloud/vite-config.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux merged commit 83aa6e5 into master Jan 24, 2024
10 checks passed
@susnux susnux deleted the enh/drop-corejs-move-vite branch January 24, 2024 20:39
@Antreesy Antreesy mentioned this pull request Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants