Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to v1.0.0-beta.19 #950

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Bump to v1.0.0-beta.19 #950

merged 1 commit into from
Oct 24, 2023

Conversation

artonge
Copy link
Contributor

@artonge artonge commented Oct 24, 2023

Needed for a proper release.

@artonge artonge added the 3. to review Waiting for reviews label Oct 24, 2023
@artonge artonge requested a review from skjnldsv October 24, 2023 08:12
@artonge artonge self-assigned this Oct 24, 2023
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #950 (575ae0e) into master (5e1b3b2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #950   +/-   ##
=======================================
  Coverage   92.30%   92.30%           
=======================================
  Files           3        3           
  Lines          78       78           
  Branches       14       14           
=======================================
  Hits           72       72           
  Misses          3        3           
  Partials        3        3           

Copy link
Contributor

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahahah

Copy link
Contributor

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, you can actually still do 19, npm have just refused it, no?
Just delete the tag, amend so it's beta 19 and push again?

@artonge artonge force-pushed the artonge/bump/1.0.0-beta.20 branch from 6356e3e to 870830b Compare October 24, 2023 12:46
@artonge
Copy link
Contributor Author

artonge commented Oct 24, 2023

Thought about it but was lazy.
Anyway, done :)

package.json Outdated Show resolved Hide resolved
Signed-off-by: Louis <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge force-pushed the artonge/bump/1.0.0-beta.20 branch from 870830b to 575ae0e Compare October 24, 2023 12:55
@skjnldsv skjnldsv changed the title Bump to v1.0.0-beta.20 Bump to v1.0.0-beta.19 Oct 24, 2023
@skjnldsv skjnldsv merged commit ba4e4a3 into master Oct 24, 2023
16 checks passed
@skjnldsv skjnldsv deleted the artonge/bump/1.0.0-beta.20 branch October 24, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants