Merge pull request #1930 from nextcloud/fix/1925/action-button-icon

Wrap icon span in icon slot for ActionButton
nextcloud-libraries · May 6, 2021 · 73b4d96 · 73b4d96
2 parents c3fe45b + 5f3cb6a
commit 73b4d96
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/src/components/ActionButton/ActionButton.vue b/src/components/ActionButton/ActionButton.vue
@@ -85,12 +85,12 @@ export default {
 			:aria-label="ariaLabel"
 			:class="{ focusable: isFocusable }"
 			@click="onClick">
-			<span :class="[isIconUrl ? 'action-button__icon--url' : icon]"
-				:style="{ backgroundImage: isIconUrl ? `url(${icon})` : null }"
-				class="action-button__icon">
-				<!-- @slot Manually provide icon -->
-				<slot name="icon" />
-			</span>
+			<!-- @slot Manually provide icon -->
+			<slot name="icon">
+				<span :class="[isIconUrl ? 'action-button__icon--url' : icon]"
+					:style="{ backgroundImage: isIconUrl ? `url(${icon})` : null }"
+					class="action-button__icon" />
+			</slot>
 
 			<!-- long text with title -->
 			<p v-if="title">