Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NcAppNavigationItem: Invalid prop: type check failed for prop "boundariesElement". Expected Element, got String with value "#content-vue" #3187

Closed
ChristophWurst opened this issue Sep 7, 2022 · 3 comments · Fixed by #3197
Labels
1. to develop Accepted and waiting to be taken care of bug Something isn't working regression Regression of a previous working feature

Comments

@ChristophWurst
Copy link
Contributor

ChristophWurst commented Sep 7, 2022

Using v7 with Mail I get

[Vue warn]: Invalid prop: type check failed for prop "boundariesElement". Expected Element, got String with value "#content-vue".

found in

---> <NcActions>
       <RouterLink>
         <NcAppNavigationItem>
           <NavigationAccount> at src/components/NavigationAccount.vue
             <NcAppNavigation>
               <Navigation> at src/components/Navigation.vue
                 <Content>
                   <Home> at src/views/Home.vue
                     <App> at src/App.vue
                       <Root> vue.runtime.esm.js:4573

Steps to reproduce

  1. Open Mail
  2. Add an account
  3. Open the account's actions menu in the navigation
@ChristophWurst ChristophWurst added bug Something isn't working 1. to develop Accepted and waiting to be taken care of labels Sep 7, 2022
@ChristophWurst
Copy link
Contributor Author

Regression of #1352 I guess

@ChristophWurst
Copy link
Contributor Author

Not sure how this should be fixed. We could have a computed prop in NcAppNavigationItem that returns the DOM element for #content-vue if it can be found.

@raimund-schluessler
Copy link
Contributor

Yeah, this was broken in #3157 where we now set the boundaries-element. Doing as you proposed should do the trick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of bug Something isn't working regression Regression of a previous working feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants