Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix actions positioning #3157

Merged
merged 1 commit into from
Sep 5, 2022
Merged

Fix actions positioning #3157

merged 1 commit into from
Sep 5, 2022

Conversation

juliusknorr
Copy link
Contributor

  • Limit height of the NcActions popover
  • Fix placement of the NCAppNavigationItem actions menu

@juliusknorr juliusknorr added bug Something isn't working 3. to review Waiting for reviews ui-refresh-feedback labels Sep 2, 2022
@juliusknorr juliusknorr added this to the 7.0.0 milestone Sep 2, 2022
@juliusknorr juliusknorr mentioned this pull request Sep 2, 2022
Merged
5 tasks
@juliusknorr juliusknorr mentioned this pull request Sep 2, 2022
Open
@raimund-schluessler
Copy link
Contributor

Will this solve #3146?

@juliusknorr
Copy link
Contributor Author

Yes, but only tested with deck so far.

@ChristophWurst ChristophWurst mentioned this pull request Sep 2, 2022
Closed
raimund-schluessler
raimund-schluessler requested changes Sep 2, 2022
View reviewed changes
Copy link
Contributor

@raimund-schluessler raimund-schluessler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that this fixes #3146.
However, I would propose to set the container properly, see https://github.com/nextcloud/nextcloud-vue/pull/3157/files#r961861481

@raimund-schluessler
Copy link
Contributor

/backport to stable6

@raimund-schluessler raimund-schluessler added the regression Regression of a previous working feature label Sep 3, 2022
@raimund-schluessler raimund-schluessler mentioned this pull request Sep 5, 2022
Merged
@GretaD
Copy link
Contributor

GretaD commented Sep 5, 2022

@raimund-schluessler Julius is on holiday, do you want to take over and deliver the(your) comments :P. I can also rebase and change the stuff as you proposed

@raimund-schluessler
Copy link
Contributor

@raimund-schluessler Julius is on holiday, do you want to take over and deliver the(your) comments :P. I can also rebase and change the stuff as you proposed

Sure, I can do that. I just didn't want to force my changes, as there might be specific reasons for the changes. But I guess we can still adjust it before a stable 6.0.0. release if necessary.

@juliusknorr @raimund-schluessler
Limit height of the NcActions popover
1ada679 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@ChristophWurst ChristophWurst merged commit e70a1df into master Sep 5, 2022
@ChristophWurst ChristophWurst deleted the bugfix/actions-popover branch September 5, 2022 11:26
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Sep 5, 2022
Merged
@szaimen szaimen mentioned this pull request Sep 5, 2022
Closed
This was referenced Sep 5, 2022
Closed
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@raimund-schluessler raimund-schluessler raimund-schluessler approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug Something isn't working regression Regression of a previous working feature ui-refresh-feedback
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@juliusknorr @raimund-schluessler @GretaD @ChristophWurst