Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not fetch user status if current user is a guest #1379

Merged
merged 1 commit into from
Sep 3, 2020
Merged

Do not fetch user status if current user is a guest #1379

merged 1 commit into from
Sep 3, 2020

Commits on Sep 2, 2020

  1. Do not fetch user status if current user is a guest 

    The user status endpoint is not available for guests, only for
logged in users. As the request will always fail if the current user is
a guest there should be no need to perform it.

Note, however, that this will prevent user statuses to be shown on the
avatars in public share pages, even if the current user is actually
logged in. Public share pages are opened in ncognito mode, so
"getCurrentUser" returns null. However, if the current user is logged in
requests to the API would work without problems, so technically it would
be possible to fetch the user statuses.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
    @danxuliu
    danxuliu committed Sep 2, 2020
    Configuration menu
    Copy the full SHA
    d848cf0 View commit details
    Browse the repository at this point in the history