Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump node-sass from 4.14.1 to 5.0.0 #1531

Closed

Conversation

dependabot-preview[bot]
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Nov 2, 2020

Bumps node-sass from 4.14.1 to 5.0.0.

Release notes

Sourced from node-sass's releases.

v5.0.0

Breaking changes

  • Only support LTS and current Node versions (@nschonni)
  • Remove deprecated process.sass API (@xzyfer, #2986)

Features

  • Add support for Node 15
  • New node-gyp version that supports building with Python 3

Community

Fixes

Supported Environments

OS Architecture Node
Windows x86 & x64 10, 12, 14, 15
OSX x64 10, 12, 14, 15
Linux* x64 10, 12, 14, 15
Alpine Linux x64 10, 12, 14, 15
FreeBSD i386 amd64 10, 12, 13

*Linux support refers to major distributions like Ubuntu, and Debian

Commits
  • 0648b5a chore: Add Node 15 support (#2983)
  • e2391c2 Add a deprecation message to the readme (#3011)
  • 6a33e53 chore: Don't upload artifacts on PRs
  • d763506 chore: Only run coverage on main repo
  • d4ebe72 build(deps): update actions/setup-node requirement to v2.1.2
  • 2bebe05 build(deps-dev): bump rimraf from 2.7.1 to 3.0.2
  • f877689 chore: Don't double build DependaBot PRs
  • b48fac4 chore: Add weekly DependaBot updates
  • 91c40a0 Remove deprecated process.sass API
  • 1f6df86 Replace lodash/assign in favor of the native Object.assign
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Bumps [node-sass](https://github.com/sass/node-sass) from 4.14.1 to 5.0.0.
- [Release notes](https://github.com/sass/node-sass/releases)
- [Changelog](https://github.com/sass/node-sass/blob/master/CHANGELOG.md)
- [Commits](sass/node-sass@v4.14.1...v5.0.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview dependabot-preview bot added 3. to review Waiting for reviews dependencies Pull requests that update a dependency file labels Nov 2, 2020
@skjnldsv
Copy link
Contributor

skjnldsv commented Nov 2, 2020

Module build failed (from ./node_modules/sass-loader/dist/cjs.js):
Error: Node Sass version 5.0.0 is incompatible with ^4.0.0.
    at getSassImplementation (/home/runner/work/nextcloud-vue/nextcloud-vue/node_modules/sass-loader/dist/utils.js:84:13)
    at Object.loader (/home/runner/work/nextcloud-vue/nextcloud-vue/node_modules/sass-loader/dist/index.js:34:59)
 @ ./src/components/PopoverMenu/PopoverMenuItem.vue?vue&type=style&index=1&id=3ad7b73b&lang=scss&scoped=true& (./node_modules/vue-style-loader!./node_modules/css-loader/dist/cjs.js!./node_modules/vue-loader/lib/loaders/stylePostLoader.js!./node_modules/resolve-url-loader!./node_modules/sass-loader/dist/cjs.js??ref--1-3!./node_modules/vue-loader/lib??vue-loader-options!./src/components/PopoverMenu/PopoverMenuItem.vue?vue&type=style&index=1&id=3ad7b73b&lang=scss&scoped=true&) 4:14-387
 @ ./src/components/PopoverMenu/PopoverMenuItem.vue?vue&type=style&index=1&id=3ad7b73b&lang=scss&scoped=true&
 @ ./src/components/PopoverMenu/PopoverMenuItem.vue
 @ ./node_modules/babel-loader/lib!./node_modules/vue-loader/lib??vue-loader-options!./src/components/PopoverMenu/PopoverMenu.vue?vue&type=script&lang=js&
 @ ./src/components/PopoverMenu/PopoverMenu.vue?vue&type=script&lang=js&
 @ ./src/components/PopoverMenu/PopoverMenu.vue
 @ ./src/components/PopoverMenu/index.js

webpack-contrib/sass-loader#898

@skjnldsv
Copy link
Contributor

skjnldsv commented Nov 2, 2020

@dependabot-bot recreate

New release have been dispatched

@skjnldsv skjnldsv closed this Nov 2, 2020
@dependabot-preview
Copy link
Contributor Author

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot-preview
Copy link
Contributor Author

Looks like this PR is closed. If you re-open it I'll rebase it as long as no-one else has edited it (you can use @dependabot reopen if the branch has been deleted).

@dependabot-preview dependabot-preview bot deleted the dependabot/npm_and_yarn/node-sass-5.0.0 branch November 2, 2020 11:45
@skjnldsv
Copy link
Contributor

skjnldsv commented Nov 2, 2020

@dependabot reopen

@dependabot-preview dependabot-preview bot reopened this Nov 2, 2020
@dependabot-preview dependabot-preview bot restored the dependabot/npm_and_yarn/node-sass-5.0.0 branch November 2, 2020 11:45
@dependabot-preview
Copy link
Contributor Author

This pull request will no longer be automatically closed when a new version is found as this pull request was created by Dependabot Preview and this repo is using a version: 2 config file. You can close this pull request and let Dependabot re-create it the next time it checks for updates.

@skjnldsv skjnldsv closed this Nov 2, 2020
@dependabot-preview dependabot-preview bot deleted the dependabot/npm_and_yarn/node-sass-5.0.0 branch November 2, 2020 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant