Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v5.1.2 #2567

Closed
wants to merge 1 commit into from
Closed

v5.1.2 #2567

wants to merge 1 commit into from

Conversation

marcoambrosini
Copy link
Contributor

Signed-off-by: marco marcoambrosini@pm.me

@marcoambrosini
v5.1.2
d4fe759 
Signed-off-by: marco <marcoambrosini@pm.me>
@marcoambrosini marcoambrosini self-assigned this Mar 22, 2022
@ChristophWurst
Copy link
Contributor

Shouldn't there be a stable5.1? Why is this off master? There are even dependency bumps on latest master, ref https://github.com/nextcloud/nextcloud-vue/commits/master. This shouldn't go into a patch release.

Also please don't forget about the changelog.

@ChristophWurst
Copy link
Contributor

I see #2553 was release in the same fashion and the changelog wasn't complete either. @skjnldsv to the rescue. What should be released off master and what from stable branches? https://github.com/nextcloud/nextcloud-vue#releasing-a-new-version doesn't tell.

@skjnldsv
Copy link
Contributor

We don't branch off minors.
We're branching off major only

@nickvergessen
Copy link
Contributor

As far as I understood basically once the first breaking change comes into master we create a stable5 and then it's split

@ChristophWurst
Copy link
Contributor

Then this should be a minor, shouldn't it? There are changes other than fixes.

@marcoambrosini
Copy link
Contributor Author

Ok, I'll do a minor and include #2566 (review)

@marcoambrosini marcoambrosini deleted the v5.1.2 branch March 23, 2022 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@artonge artonge artonge approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@JuliaKirschenheuter JuliaKirschenheuter Awaiting requested review from JuliaKirschenheuter

@julien-nc julien-nc Awaiting requested review from julien-nc

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@vanpertsch vanpertsch Awaiting requested review from vanpertsch

Assignees

@marcoambrosini marcoambrosini

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@marcoambrosini @ChristophWurst @skjnldsv @nickvergessen @artonge