-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix HTML validation of AppNavigationToggle #2846
Conversation
nickvergessen
commented
Jul 15, 2022
Error: Attribute icon not allowed on element button at this point. Signed-off-by: Joas Schilling <coding@schilljs.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hope i've understtod the problem right. Question: why not to fix this in https://github.com/nextcloud/nextcloud-vue/blob/de5b332374428795cac78b2a534af02ead8b0af0/src/components/ActionButton/ActionButton.vue#L79 and use src/components/Button/Button.vue instead?
My suggestin is that we still need an ActionButton inside of AppNavigationToggle. But i also could be wrong.
The Actions menu with 1 entry is a "hack" from before we had the buttons component. We should use the button component directly to ease the code. |
/backport to stable5 |