Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't regard 1024px width viewport as mobile #3768

Merged
merged 1 commit into from
Feb 17, 2023
Merged

Don't regard 1024px width viewport as mobile #3768

merged 1 commit into from
Feb 17, 2023

Conversation

mejo-
Copy link
Contributor

@mejo- mejo- commented Feb 16, 2023 •
edited
Loading

  • In IsMobileState.js we treat viewports smaller 1024px as mobile.
  • In NcAppContent.vue we treat viewports starting with 1024px as mobile.

This results in weird behaviour with screens that have exactly 1024px width. E.g., on three-pane apps, NcAppContentList is hidden but the NcAppDetailsToggle button is not displayed yet.

This commit changes NcAppContent.vue to treat viewports smaller 1024px as mobile, to be in sync with IsMobileState.js.

This PR accompanies nextcloud/server#36751.

Both are required to fix #3758.

Fixes: #3758

@mejo- mejo- added bug Something isn't working 3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities labels Feb 16, 2023
@mejo- mejo- added this to the 7.7.0 milestone Feb 16, 2023
@mejo-
Don' regard 1024px width viewport as mobile
6d69022 
* In IsMobileState.js we treat viewports smaller 1024px as mobile.
* In NcAppContent.vue we treat viewports starting with 1024px as mobile.

This results in weird behaviour with screens that have exactly 1024px
width. E.g., on three-pane apps, NcAppContentList is hidden but the
NcAppDetailsToggle button is not displayed yet.

This commit changes NcAppContent.vue to treat viewports smaller 1024px
as mobile, to be in sync with IsMobileState.js.

This PR accompanies nextcloud/server#36751.

Both are required to fix
#3758.

Fixes: #3758

Signed-off-by: Jonas <jonas@freesources.org>
mejo- added a commit to nextcloud/server that referenced this pull request Feb 16, 2023
@mejo-
Don't regard 1024px width viewport as mobile
c1a8207 
Currently we treat 1024px as mobile in some places (e.g. `isMobile` in
nextcloud-vue) and as not mobile yet in others (e.g. in mobile.css).

This commit changes `mobile.scss` to treat viewports smaller than 1024px
as mobile.

This PR accompanies nextcloud-libraries/nextcloud-vue#3768

Both are required to fix
nextcloud-libraries/nextcloud-vue#3758.

Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- mentioned this pull request Feb 16, 2023
Merged
2 tasks
@mejo- mejo- force-pushed the fix/mobile_breakpoint branch from 0b5e4d2 to 6d69022 Compare February 16, 2023 11:21
@mejo- mejo- mentioned this pull request Feb 16, 2023
Closed
@mejo- mejo- changed the title Don' regard 1024px width viewport as mobile Don't regard 1024px width viewport as mobile Feb 16, 2023
ChristophWurst
ChristophWurst approved these changes Feb 16, 2023
View reviewed changes
Copy link
Contributor

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should fix nextcloud/mail#7990 too

@raimund-schluessler
Copy link
Contributor

Shouldn't we also adjust this here
https://github.com/nextcloud/nextcloud-vue/blob/8342cda8a128da49b421bd24edf3b1c928a152c6/src/components/NcAppNavigation/NcAppNavigation.vue#L189-L196
and here
https://github.com/nextcloud/nextcloud-vue/blob/c80a585a2eef2bd1057917271c1ce0d2dabd02a6/src/components/NcModal/NcModal.vue#L936
and here
https://github.com/nextcloud/nextcloud-vue/blob/c53599ed09b68d1e00c134c0fc2405848c162548/src/components/NcAppSidebar/NcAppSidebar.vue#L881

@raimund-schluessler
Copy link
Contributor

Shouldn't we also adjust this here

Let's move on with this and adjust the rest later.

@max-nextcloud max-nextcloud merged commit b50f179 into master Feb 17, 2023
@max-nextcloud max-nextcloud deleted the fix/mobile_breakpoint branch February 17, 2023 14:46
@max-nextcloud max-nextcloud mentioned this pull request Feb 17, 2023
Open
backportbot-nextcloud bot pushed a commit to nextcloud/server that referenced this pull request Feb 17, 2023
@mejo- @backportbot-nextcloud
Don't regard 1024px width viewport as mobile
9d6e755 
Currently we treat 1024px as mobile in some places (e.g. `isMobile` in
nextcloud-vue) and as not mobile yet in others (e.g. in mobile.css).

This commit changes `mobile.scss` to treat viewports smaller than 1024px
as mobile.

This PR accompanies nextcloud-libraries/nextcloud-vue#3768

Both are required to fix
nextcloud-libraries/nextcloud-vue#3758.

Signed-off-by: Jonas <jonas@freesources.org>
mejo- added a commit to nextcloud/server that referenced this pull request Feb 18, 2023
@mejo-
Don't regard 1024px width viewport as mobile
5e06e63 
Currently we treat 1024px as mobile in some places (e.g. `isMobile` in
nextcloud-vue) and as not mobile yet in others (e.g. in mobile.css).

This commit changes `mobile.scss` to treat viewports smaller than 1024px
as mobile.

This PR accompanies nextcloud-libraries/nextcloud-vue#3768

Both are required to fix
nextcloud-libraries/nextcloud-vue#3758.

Signed-off-by: Jonas <jonas@freesources.org>
mejo- added a commit to nextcloud/server that referenced this pull request Feb 18, 2023
@mejo-
Don't regard 1024px width viewport as mobile
fa10818 
Currently we treat 1024px as mobile in some places (e.g. `isMobile` in
nextcloud-vue) and as not mobile yet in others (e.g. in mobile.css).

This commit changes `mobile.scss` to treat viewports smaller than 1024px
as mobile.

This PR accompanies nextcloud-libraries/nextcloud-vue#3768

Both are required to fix
nextcloud-libraries/nextcloud-vue#3758.

Signed-off-by: Jonas <jonas@freesources.org>
@szaimen szaimen mentioned this pull request Feb 20, 2023
Merged
nextcloud-command pushed a commit to nextcloud/server that referenced this pull request Feb 26, 2023
@mejo- @MichaIng
Don't regard 1024px width viewport as mobile
9cf7ed4 
Currently we treat 1024px as mobile in some places (e.g. `isMobile` in
nextcloud-vue) and as not mobile yet in others (e.g. in mobile.css).

This commit changes `mobile.scss` to treat viewports smaller than 1024px
as mobile.

This PR accompanies nextcloud-libraries/nextcloud-vue#3768

Both are required to fix
nextcloud-libraries/nextcloud-vue#3758.

Signed-off-by: Jonas <jonas@freesources.org>
RonaldBarnes pushed a commit to RonaldBarnes/NextCloud-server that referenced this pull request Mar 1, 2023
@mejo- @RonaldBarnes
Don't regard 1024px width viewport as mobile
e314128 
Currently we treat 1024px as mobile in some places (e.g. `isMobile` in
nextcloud-vue) and as not mobile yet in others (e.g. in mobile.css).

This commit changes `mobile.scss` to treat viewports smaller than 1024px
as mobile.

This PR accompanies nextcloud-libraries/nextcloud-vue#3768

Both are required to fix
nextcloud-libraries/nextcloud-vue#3758.

Signed-off-by: Jonas <jonas@freesources.org>
summersab pushed a commit to summersab/server that referenced this pull request Jun 25, 2023
@mejo- @summersab
Don't regard 1024px width viewport as mobile
e38ba43 
Currently we treat 1024px as mobile in some places (e.g. `isMobile` in
nextcloud-vue) and as not mobile yet in others (e.g. in mobile.css).

This commit changes `mobile.scss` to treat viewports smaller than 1024px
as mobile.

This PR accompanies nextcloud-libraries/nextcloud-vue#3768

Both are required to fix
nextcloud-libraries/nextcloud-vue#3758.

Signed-off-by: Jonas <jonas@freesources.org>
summersab pushed a commit to summersab/server that referenced this pull request Jun 25, 2023
@mejo- @summersab
Don't regard 1024px width viewport as mobile
954b3c0 
Currently we treat 1024px as mobile in some places (e.g. `isMobile` in
nextcloud-vue) and as not mobile yet in others (e.g. in mobile.css).

This commit changes `mobile.scss` to treat viewports smaller than 1024px
as mobile.

This PR accompanies nextcloud-libraries/nextcloud-vue#3768

Both are required to fix
nextcloud-libraries/nextcloud-vue#3758.

Signed-off-by: Jonas <jonas@freesources.org>
summersab pushed a commit to summersab/server that referenced this pull request Jun 25, 2023
@mejo- @summersab
Don't regard 1024px width viewport as mobile
2ad695d 
Currently we treat 1024px as mobile in some places (e.g. `isMobile` in
nextcloud-vue) and as not mobile yet in others (e.g. in mobile.css).

This commit changes `mobile.scss` to treat viewports smaller than 1024px
as mobile.

This PR accompanies nextcloud-libraries/nextcloud-vue#3768

Both are required to fix
nextcloud-libraries/nextcloud-vue#3758.

Signed-off-by: Jonas <jonas@freesources.org>
summersab pushed a commit to summersab/server that referenced this pull request Jun 25, 2023
@mejo- @summersab
Don't regard 1024px width viewport as mobile
5acb36e 
Currently we treat 1024px as mobile in some places (e.g. `isMobile` in
nextcloud-vue) and as not mobile yet in others (e.g. in mobile.css).

This commit changes `mobile.scss` to treat viewports smaller than 1024px
as mobile.

This PR accompanies nextcloud-libraries/nextcloud-vue#3768

Both are required to fix
nextcloud-libraries/nextcloud-vue#3758.

Signed-off-by: Jonas <jonas@freesources.org>
summersab pushed a commit to summersab/server that referenced this pull request Jun 25, 2023
@mejo- @summersab
Don't regard 1024px width viewport as mobile
aaf0c79 
Currently we treat 1024px as mobile in some places (e.g. `isMobile` in
nextcloud-vue) and as not mobile yet in others (e.g. in mobile.css).

This commit changes `mobile.scss` to treat viewports smaller than 1024px
as mobile.

This PR accompanies nextcloud-libraries/nextcloud-vue#3768

Both are required to fix
nextcloud-libraries/nextcloud-vue#3758.

Signed-off-by: Jonas <jonas@freesources.org>
summersab pushed a commit to summersab/server that referenced this pull request Jun 26, 2023
@mejo- @summersab
Don't regard 1024px width viewport as mobile
b96e887 
Currently we treat 1024px as mobile in some places (e.g. `isMobile` in
nextcloud-vue) and as not mobile yet in others (e.g. in mobile.css).

This commit changes `mobile.scss` to treat viewports smaller than 1024px
as mobile.

This PR accompanies nextcloud-libraries/nextcloud-vue#3768

Both are required to fix
nextcloud-libraries/nextcloud-vue#3758.

Signed-off-by: Jonas <jonas@freesources.org>
summersab pushed a commit to summersab/server that referenced this pull request Jun 26, 2023
@mejo- @summersab
Don't regard 1024px width viewport as mobile
302bb62 
Currently we treat 1024px as mobile in some places (e.g. `isMobile` in
nextcloud-vue) and as not mobile yet in others (e.g. in mobile.css).

This commit changes `mobile.scss` to treat viewports smaller than 1024px
as mobile.

This PR accompanies nextcloud-libraries/nextcloud-vue#3768

Both are required to fix
nextcloud-libraries/nextcloud-vue#3758.

Signed-off-by: Jonas <jonas@freesources.org>
summersab pushed a commit to summersab/server that referenced this pull request Jun 26, 2023
@mejo- @summersab
Don't regard 1024px width viewport as mobile
fff0618 
Currently we treat 1024px as mobile in some places (e.g. `isMobile` in
nextcloud-vue) and as not mobile yet in others (e.g. in mobile.css).

This commit changes `mobile.scss` to treat viewports smaller than 1024px
as mobile.

This PR accompanies nextcloud-libraries/nextcloud-vue#3768

Both are required to fix
nextcloud-libraries/nextcloud-vue#3758.

Signed-off-by: Jonas <jonas@freesources.org>
summersab pushed a commit to summersab/server that referenced this pull request Jun 26, 2023
@mejo- @summersab
Don't regard 1024px width viewport as mobile
1539490 
Currently we treat 1024px as mobile in some places (e.g. `isMobile` in
nextcloud-vue) and as not mobile yet in others (e.g. in mobile.css).

This commit changes `mobile.scss` to treat viewports smaller than 1024px
as mobile.

This PR accompanies nextcloud-libraries/nextcloud-vue#3768

Both are required to fix
nextcloud-libraries/nextcloud-vue#3758.

Signed-off-by: Jonas <jonas@freesources.org>
summersab pushed a commit to summersab/server that referenced this pull request Jun 26, 2023
@mejo- @summersab
Don't regard 1024px width viewport as mobile
a3fb855 
Currently we treat 1024px as mobile in some places (e.g. `isMobile` in
nextcloud-vue) and as not mobile yet in others (e.g. in mobile.css).

This commit changes `mobile.scss` to treat viewports smaller than 1024px
as mobile.

This PR accompanies nextcloud-libraries/nextcloud-vue#3768

Both are required to fix
nextcloud-libraries/nextcloud-vue#3758.

Signed-off-by: Jonas <jonas@freesources.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raimund-schluessler raimund-schluessler raimund-schluessler approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@brueckner brueckner Awaiting requested review from brueckner

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees
No one assigned
Labels
3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities bug Something isn't working
Projects
None yet
Milestone
7.7.0
Development

Successfully merging this pull request may close these issues.

NcAppDetailsToggle missing with viewport width 1024px
4 participants
@mejo- @raimund-schluessler @ChristophWurst @max-nextcloud