Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust breadcrumb CSS to new html structure #4026

Merged
merged 1 commit into from
May 2, 2023

Conversation

raimund-schluessler
Copy link
Contributor

@raimund-schluessler raimund-schluessler commented May 2, 2023

This adjusts the CSS of the NcBreadcrumbs component to the new HTML structure changed in #3990. After #3990 the breadcrumbs would not shrink correctly anymore on small screens, this PR fixes it.

Before (overlaps the NcActions on the right):
grafik

After (no overlap, correctly shrinks):
grafik

Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
@raimund-schluessler raimund-schluessler added 3. to review Waiting for reviews feature: breadcrumbs Related to the breadcrumbs components labels May 2, 2023
@raimund-schluessler raimund-schluessler added this to the 7.11.0 milestone May 2, 2023
@raimund-schluessler raimund-schluessler marked this pull request as ready for review May 2, 2023 19:15
@raimund-schluessler raimund-schluessler merged commit 5a1cd32 into master May 2, 2023
@raimund-schluessler raimund-schluessler deleted the fix/noid/breadcrumb-a11y-fixup branch May 2, 2023 20:37
@artonge artonge mentioned this pull request May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews feature: breadcrumbs Related to the breadcrumbs components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants