Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NcAppSidebar): apply toggle offset transition only on sidebar transition #5720

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Jun 19, 2024

☑️ Resolves

  • There is a transition for the sidebar toggle button
  • It makes sense when the sidebar is opening/closing
  • It looks like a glitch initially when it appears

🖼️ Screenshots

Slowed down to be more visible on gifs

🏚️ Before 🏡 After
sidebar-toggle-appear-before sidebar-toggle-appear-after
sidebar-toggle-slide sidebar-toggle-slide

🚧 Tasks

  • Disable --app-sidebar-offset transition by default
  • Enable --app-sidebar-offset transition when NcAppSidebar transition is active
  • Make sure it has no changes for sliding

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

…nsition

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme added bug Something isn't working 3. to review Waiting for reviews feature: app-sidebar Related to the app-sidebar component labels Jun 19, 2024
@ShGKme ShGKme added this to the 8.13.0 milestone Jun 19, 2024
@ShGKme ShGKme self-assigned this Jun 19, 2024
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@ShGKme ShGKme merged commit 6dcce53 into master Jun 19, 2024
19 checks passed
@ShGKme ShGKme deleted the fix/NcAppSidebar--remove-toggle-animation-on-appear branch June 19, 2024 17:45
@ShGKme
Copy link
Contributor Author

ShGKme commented Jun 19, 2024

/backport to next

Copy link

backportbot bot commented Jun 19, 2024

The backport to next failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout next
git pull origin next

# Create the new backport branch
git checkout -b backport/5720/next

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick d5a2a7a9

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/5720/next

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews backport-request bug Something isn't working feature: app-sidebar Related to the app-sidebar component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants