-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add nextcloud-vue-import-transform script #5731
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
60eade1
to
0ec1c7c
Compare
Maybe it makes sense to have this in the eslint plugin or so? |
Makes sense but I wanted to play with different apps to see if it actually makes result better, not worse. |
As soon as you use But this is especially helpful for libraries that are later used by Webpack, like nc dialogs. |
|
||
const MIXIN_NAMES = ['clickOutsideOptions', 'isFullscreen', 'isMobile', 'richEditor', 'userStatus'] | ||
const DIRECTIVE_NAMES = ['Focus', 'Linkify', 'Tooltip'] | ||
const modulesMap = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any chance to update this map automatically?
☑️ Resolves
@nextcloud/vue
imports nextcloud/firstrunwizard#1262Imports from re-export are not optimal, having tree-shaking issues
Individual imports are more optimal
But changing it manually is painful for a huge app.
This script makes it automatically and tells if some imports cannot be processed.
Example