Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style(NcAvatar): make button element round as avatar itself #5898

Merged
merged 1 commit into from
Aug 5, 2024
Merged

style(NcAvatar): make button element round as avatar itself #5898

merged 1 commit into from
Aug 5, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Aug 2, 2024 •
edited
Loading

☑️ Resolves

  • Fix focus-visible state appearance
  • parent > children syntax to avoid leaking to NcActionsButtons

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@Antreesy
style(NcAvatar): make button element round as avatar itself
c003585 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy added 3. to review Waiting for reviews design Design, UX, interface and interaction design feature: avatar Related to the avatar component labels Aug 2, 2024
@Antreesy Antreesy added this to the 8.15.2 milestone Aug 2, 2024
@Antreesy Antreesy requested review from susnux and ShGKme August 2, 2024 13:39
@Antreesy Antreesy self-assigned this Aug 2, 2024
@Antreesy
Copy link
Contributor Author

Antreesy commented Aug 2, 2024

/backport to next

@ShGKme ShGKme modified the milestones: 8.15.2, 8.16.0 Aug 3, 2024
@Antreesy Antreesy requested a review from DorraJaouad August 5, 2024 06:53
DorraJaouad
DorraJaouad approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NcAvatar is using border-radius: 50%; to define it. I suggest to all be aligned with half the size calculation.

@susnux
Copy link
Contributor

susnux commented Aug 5, 2024

NcAvatar is using border-radius: 50%; to define it. I suggest to all be aligned with half the size calculation.

I think 50% is faster (not sure if this is measurable) and probably easier to understand?
But lets make it consistent in a followup

@susnux susnux merged commit 9e13fd6 into master Aug 5, 2024
19 checks passed
@susnux susnux deleted the fix/noid/ncavatar-pill-menu branch August 5, 2024 09:56
@backportbot backportbot bot mentioned this pull request Aug 5, 2024
Merged
@Antreesy Antreesy mentioned this pull request Aug 5, 2024
Merged
3 tasks
@Antreesy Antreesy added the bug Something isn't working label Aug 5, 2024
@Antreesy Antreesy mentioned this pull request Aug 5, 2024
Merged
@Stanislav1975 Stanislav1975 mentioned this pull request Aug 26, 2024
Open
This was referenced Sep 6, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DorraJaouad DorraJaouad DorraJaouad approved these changes

@susnux susnux susnux approved these changes

@ShGKme ShGKme Awaiting requested review from ShGKme

Assignees

@Antreesy Antreesy

Labels
3. to review Waiting for reviews bug Something isn't working design Design, UX, interface and interaction design feature: avatar Related to the avatar component
Projects
None yet
Milestone
8.16.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Antreesy @susnux @DorraJaouad @ShGKme