-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(NcCounterBubble): make it perfectly aligned circle #5948
Conversation
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Just to note: Can we not just make it min-width min-height 1em and center it? Then it is always perfect? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works, but see comment :)
How? |
To center it, you need to know the size and the position of the character relative to the container |
/backport to next |
☑️ Resolves
NcUserBubble
the digit is not exactly in the middle1em
line height is bigger than actual digit heightcap
fixes the problemcap
is not well supported, so using1em
as a fallback🖼️ Screenshots
🏁 Checklist
next
requested with a Vue 3 upgrade