Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NcHeaderMenu): Ensure trigger button is has same width as wrapper #6047

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Sep 3, 2024

☑️ Resolves

Make sure the header button is correctly resized on small screen.
Before only the outer container was resized but the inner button was larger than the container -> scroll bars were shown.

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added bug Something isn't working 3. to review Waiting for reviews feature: header-menu labels Sep 3, 2024
@susnux susnux added this to the 8.18.0 milestone Sep 3, 2024
@susnux
Copy link
Contributor Author

susnux commented Sep 3, 2024

/backport to next

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working feature: header-menu
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants