Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NcDateTimePicker): change styling to look more like the native picker #6095

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

GretaD
Copy link
Contributor

@GretaD GretaD commented Sep 16, 2024

☑️ Resolves

🖼️ Screenshots

🏚️ Before | 🏡 After
after
Screenshot from 2024-09-30 11-52-42

🚧 Tasks

  • ...

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@GretaD GretaD added the 3. to review Waiting for reviews label Sep 16, 2024
@GretaD GretaD self-assigned this Sep 16, 2024
@GretaD GretaD added the enhancement New feature or request label Sep 16, 2024
@ShGKme ShGKme added bug Something isn't working feature: datepicker Related to the date/time picker component design Design, UX, interface and interaction design and removed enhancement New feature or request labels Sep 16, 2024
@ShGKme ShGKme changed the title feat: change the datepicker styling to look more like the native picker fix(NcDateTimePicker): change styling to look more like the native picker Sep 16, 2024
@susnux susnux added this to the 8.19.1 milestone Sep 17, 2024
Copy link

@nimishavijay nimishavijay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good! Very big improvement when we compare it to the current design :)

  • Is it possible to hide the first row in this case? The topmost week that is shown should be the week containing the 1st of the month (eg. we are on September but the last week of August is also shown)
  • Is it possible to hide the double arrows which skip to the same month next year (« and ») since I imagine that functionality is not used very often. This would also provide more horizontal space for the month name :)
  • As @susnux mentioned the size should be a variable (--clickable-area-small should work here)
  • Nice-to-have: Show full month name

@GretaD GretaD marked this pull request as draft September 25, 2024 14:54
@GretaD
Copy link
Contributor Author

GretaD commented Sep 26, 2024

Looks really good! Very big improvement when we compare it to the current design :)

  • Is it possible to hide the first row in this case? The topmost week that is shown should be the week containing the 1st of the month (eg. we are on September but the last week of August is also shown)

Unfortunately, i cannot find a way, but i removed the background color, so it doesnt look too crowded.

The rest is done. I updated to screenshot

@GretaD GretaD marked this pull request as ready for review September 26, 2024 13:01
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice, but it is no longer possible to select a year that is more in the past / future as the buttons are removed:

before now
image image

Also when selecting the month the year should be centered like before:

before now
image image

@GretaD
Copy link
Contributor Author

GretaD commented Sep 30, 2024

Looks nice, but it is no longer possible to select a year that is more in the past / future as the buttons are removed:

ahhh thanks for testing it, @nimishavijay i guess we need the buttons :D

@GretaD GretaD requested a review from susnux September 30, 2024 09:58
@st3iny
Copy link
Contributor

st3iny commented Sep 30, 2024

Please also have a look at #6125. I missed that you were also working on the date picker design 🙈

Ref nextcloud/calendar#6324

@GretaD
Copy link
Contributor Author

GretaD commented Sep 30, 2024

Please also have a look at #6125. I missed that you were also working on the date picker design 🙈

Ref nextcloud/calendar#6324

we can merge them, no problem, the change is the same, with small difference, like the hover button state. Do you want to include mine at yours, or should i add yours here?

@GretaD GretaD force-pushed the improve/datetimepicker branch from de40c8a to dedbceb Compare October 22, 2024 07:40
@GretaD GretaD merged commit 91a7841 into master Oct 22, 2024
19 checks passed
@GretaD GretaD deleted the improve/datetimepicker branch October 22, 2024 07:42
@Antreesy Antreesy modified the milestones: 8.19.1, 8.20.0 Oct 29, 2024
@ShGKme
Copy link
Contributor

ShGKme commented Nov 5, 2024

/backport to next

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working design Design, UX, interface and interaction design feature: datepicker Related to the date/time picker component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants