Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcInputField): icon position in RTL #6202

Merged
merged 1 commit into from
Nov 11, 2024
Merged

fix(NcInputField): icon position in RTL #6202

merged 1 commit into from
Nov 11, 2024

Conversation

alsulami1
Copy link
Contributor

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
security_icon_bug fixed_security_icon_bug

@alsulami1
fix(NcInputField): Fix input fields icon postion in RTL
42efef1 
Signed-off-by: alsulami1 <ntisahmed@gmail.com>
@ShGKme ShGKme added bug Something isn't working 3. to review Waiting for reviews feature: input-field Covering the InputField, TextField, ... labels Nov 11, 2024
@ShGKme ShGKme added this to the 8.20.0 milestone Nov 11, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.74%. Comparing base (38d3afe) to head (42efef1).
Report is 300 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6202      +/-   ##
==========================================
+ Coverage   37.86%   42.74%   +4.87%     
==========================================
  Files         148      153       +5     
  Lines        5261     4029    -1232     
  Branches     1577     1015     -562     
==========================================
- Hits         1992     1722     -270     
+ Misses       3185     2195     -990     
- Partials       84      112      +28

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ShGKme
ShGKme approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ShGKme ShGKme requested a review from hamza221 November 11, 2024 10:17
@ShGKme ShGKme enabled auto-merge November 11, 2024 10:24
@ShGKme ShGKme changed the title fix(NcInputField): Fix input fields icon postion in RTL fix(NcInputField): icon position in RTL Nov 11, 2024
@Antreesy Antreesy modified the milestones: 8.20.0, 8.20.1 Nov 11, 2024
@susnux susnux disabled auto-merge November 11, 2024 19:57
@susnux susnux merged commit a1ac1c8 into nextcloud-libraries:master Nov 11, 2024
17 checks passed
@susnux
Copy link
Contributor

susnux commented Nov 11, 2024

/backport to next

@backportbot backportbot bot mentioned this pull request Nov 11, 2024
Merged
@Antreesy Antreesy mentioned this pull request Nov 21, 2024
Merged
@Antreesy Antreesy modified the milestones: 8.20.1, 8.21.0 Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamza221 hamza221 hamza221 approved these changes

@ShGKme ShGKme ShGKme approved these changes

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug Something isn't working feature: input-field Covering the InputField, TextField, ...
Projects
None yet
Milestone
8.21.0
Development

Successfully merging this pull request may close these issues.

[Bug]: Input fields icon positioning in RTL mode
5 participants
@alsulami1 @susnux @ShGKme @hamza221 @Antreesy