Add @babel/runtime

[juliusknorr]

Fixes #691

According to https://babeljs.io/docs/en/babel-plugin-transform-runtime @babel/plugin-transform-runtime requires @babel/runtime as a production dependency.

@skjnldsv @ChristophWurst I though babel/polyfill should no longer be needed. Still seems to work fine with IE11 if the app is taking care of a proper babel tranformation. It was not imported in @nextcloud/vue anyway.

[skjnldsv]

I'm not sure we still needs the babel/plugin-transform-xxx to be honest.
We should probably just import core-js and use preset-env with a proper useBuiltIns config 🤔

[korelstar]

Why does nextcloud-vue need babel/core-js at all? Isn't it sufficient if the apps using nextcloud-vue use babel/core-js?

[skjnldsv]

Why does nextcloud-vue need babel/core-js at all? Isn't it sufficient if the apps using nextcloud-vue use babel/core-js?

They need to specifically specify to babel to include the vue components then :)
It's much easier to make sure we're compatible with the same config here than to put all the transpile weight on the apps.
https://github.com/nextcloud/server/blob/c280eff9b5daa0cf85322b00e38662c1ff4fc7bd/webpack.common.js#L83

[raimund-schluessler]

I don't really know how to test this. Checking out the branch, running make and copying the dist folder to tasks\node_modules\@nextcloud\vue\dist\ does not solve the issue. Also, replacing "@babel/polyfill": "^7.4.4", with "@babel/runtime": "^7.6.3", in tasks\node_modules\@nextcloud\vue\package.json does not help.

[juliusknorr]

Ok I guess in that case we should make sure that tthe required transpiling packages are not excluded in the wepack config since #679 just excluded all

[korelstar]

#691 did also appear for me. After using this PR the issue was fixed. I'm not sure if the steps by @raimund-schluessler are sufficient to test this. Here is what I did:

• in my local nextcloud-vue clone, checkout this branch
• execute npm install, make build-js-production, npm link
• in my app's directory, execute npm link @nextcloud/vue, make build-js
• everything is fine :-)

my tests where not sufficient, now the error is not reproducable any more

[korelstar]

Okay, I did the test wrong. But I think adding @babel/runtime to the app's dependencies solves the issue. In order to enforce apps to install @babel/runtime, we could add it as peer-dependeny to nextcloud-vue. Wouldn't that solve the issue?

[raimund-schluessler]

#691 did also appear for me. After using this PR the issue was fixed. I'm not sure if the steps by @raimund-schluessler are sufficient to test this. Here is what I did:

* in my local `nextcloud-vue` clone, checkout this branch

* execute `npm install`, `make build-js-production`, `npm link`

* in my app's directory, execute `npm link @nextcloud/vue`, `make build-js`

* everything is fine :-)

Following this seems to fix the issue for Tasks. 👍

[skjnldsv]

if the app is taking care of a proper babel tranformation.

this does not happen.
Remember that the app should not be in charge of transpiling the node_modules. This should be done only on very rare specific occasions :)

[juliusknorr]

Remember that the app should not be in charge of transpiling the node_modules. This should be done only on very rare specific occasions :)

I actually think this should be the apps responsibility. Other libraries also just ship their ES6 modules and the app needs to handle making them compatible to the browser stack that should be supported. General transpiling is done in @nextcloud/vue (e.g. for icon fonts) but we should do babel transformations ourselves.

[skjnldsv]

so, what is the status here? :)

[korelstar]

I agree with @juliushaertl and vote for removing babel/corejs from @nextcloud/vue and let the apps do this part. Typically, they have to do it anyway (for their own code).

[skjnldsv]

As a comparison, out datepicker recently release 3.0.0, where they added babel to be compatible with ie. I think it's less trivial to have default working deps than having to do webpack trick to include specific packages in the transpiler.

https://github.com/nextcloud/server/blob/4ddea4bdfbc36e13f7b397a1d881ddff2d364419/webpack.common.js#L86

[ChristophWurst]

As a comparison, out datepicker recently release 3.0.0, where they added babel to be compatible with ie. I think it's less trivial to have default working deps than having to do webpack trick to include specific packages in the transpiler.

Second that. I would also argue that we should transpile this lib already, given that we have a shared browserslist config and thus know what apps most likely want to be compatible with.

[ChristophWurst]

We should probably just import core-js and use preset-env with a proper useBuiltIns config

Can we give that a try?

[raimund-schluessler]

So what do I have to do to get nextcloud/tasks#688 running?

[skjnldsv]

Fix in #749