Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/641/use popover component for actions #832

Merged
merged 3 commits into from
Aug 20, 2020
Merged

Feature/641/use popover component for actions #832

merged 3 commits into from
Aug 20, 2020

Conversation

marcoambrosini
Copy link
Contributor

@marcoambrosini marcoambrosini commented Jan 24, 2020 •
edited
Loading

fix #641

skjnldsv
skjnldsv reviewed Jan 24, 2020
View reviewed changes
src/assets/action.scss Outdated Show resolved Hide resolved
skjnldsv
skjnldsv reviewed Jan 24, 2020
View reviewed changes
src/assets/action.scss Outdated Show resolved Hide resolved
@marcoambrosini marcoambrosini force-pushed the feature/641/use-popover-component-for-actions branch 2 times, most recently from 2dff47a to 2667e6a Compare January 27, 2020 11:05
@marcoambrosini marcoambrosini self-assigned this Jan 27, 2020
@skjnldsv skjnldsv mentioned this pull request Mar 25, 2020
Merged
3 tasks
@skjnldsv

This comment has been minimized.

Sign in to view
@marcoambrosini marcoambrosini mentioned this pull request Mar 25, 2020
Merged
@georgehrke

This comment has been minimized.

Sign in to view
@skjnldsv skjnldsv mentioned this pull request Aug 6, 2020
Merged
@skjnldsv skjnldsv force-pushed the feature/641/use-popover-component-for-actions branch from 2667e6a to e09a1c8 Compare August 6, 2020 07:03
@skjnldsv skjnldsv self-assigned this Aug 6, 2020
@skjnldsv skjnldsv marked this pull request as ready for review August 6, 2020 07:04
@skjnldsv
Copy link
Contributor

skjnldsv commented Aug 6, 2020

So, one issue is Actions inside a menu.
Since the menu is now out of the component, it is dedected by the click-outside directive and close everything on click.

Anyone have any idea?

@skjnldsv skjnldsv added 2. developing Work in progress design Design, UX, interface and interaction design enhancement New feature or request feature: actions Related to the actions components labels Aug 6, 2020
georgehrke
georgehrke suggested changes Aug 6, 2020
View reviewed changes
Copy link
Contributor

@georgehrke georgehrke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can't access the actions with keyboard only.
Arrow Up / Arrow Down does nothing.

@georgehrke
Copy link
Contributor

So, one issue is Actions inside a menu.
Since the menu is now out of the component, it is dedected by the click-outside directive and close everything on click.

We can probably use #983 and whitelist the popover class?

@skjnldsv
Copy link
Contributor

skjnldsv commented Aug 6, 2020

We can probably use #983 and whitelist the popover class?

Would be great yes! :)

@skjnldsv skjnldsv force-pushed the feature/641/use-popover-component-for-actions branch from afe4a45 to e0f3c29 Compare August 7, 2020 12:48
@skjnldsv
Copy link
Contributor

skjnldsv commented Aug 10, 2020 •
edited
Loading

So, I'm close to it, but I'm stuck.
It focus the first entry on open, but never the first time it is opened 🤔
Anyone wanna help? @nextcloud/vuejs

marcoambrosini and others added 2 commits August 19, 2020 17:07
@marcoambrosini @skjnldsv
Add popover component
24ab154 
Signed-off-by: Marco Ambrosini <marcoambrosini@pm.me>
@skjnldsv
Make popover styling standalone
6721935 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv force-pushed the feature/641/use-popover-component-for-actions branch from d157c6b to 6721935 Compare August 19, 2020 15:07
@skjnldsv
L10n extract
ff4ee08 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
georgehrke
georgehrke approved these changes Aug 20, 2020
View reviewed changes
Copy link
Contributor

@georgehrke georgehrke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor issue:

  • The popover doesn't automatically close when tabbing over the last item

@skjnldsv skjnldsv merged commit 93f5f2f into master Aug 20, 2020
@skjnldsv skjnldsv deleted the feature/641/use-popover-component-for-actions branch August 20, 2020 15:14
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Aug 20, 2020
@skjnldsv skjnldsv mentioned this pull request Aug 20, 2020
Closed
@PVince81 PVince81 mentioned this pull request Nov 24, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgehrke georgehrke georgehrke approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@jotoeri jotoeri Awaiting requested review from jotoeri

@violoncelloCH violoncelloCH Awaiting requested review from violoncelloCH

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@korelstar korelstar Awaiting requested review from korelstar

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

Assignees

@skjnldsv skjnldsv

@marcoambrosini marcoambrosini

Labels
4. to release Ready to be released and/or waiting for tests to finish design Design, UX, interface and interaction design enhancement New feature or request feature: actions Related to the actions components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use the Popover component for Actions
3 participants
@marcoambrosini @skjnldsv @georgehrke