Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: Update stylelint to 16.2.0 #92

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jan 22, 2024

  • stylelint-config-recommended-scss to 14.0.0
  • stylelint-config-recommended-vue to 1.5.0

❗ the rules for indention and string-quotes are deprecated for quite some time and now removed as stylelint, same as eslint, do not provide any stylistic rules anymore.
Both recommend to use prettier for stylistic rules instead.

@susnux susnux added the 3. to review Waiting for reviews label Jan 22, 2024
@susnux susnux requested review from skjnldsv and Pytal January 22, 2024 17:26
@susnux susnux changed the title chore: Update stylelint to 16.2.0 chore!: Update stylelint to 16.2.0 Jan 22, 2024
@Pytal
Copy link
Contributor

Pytal commented Jan 22, 2024

Both recommend to use prettier for stylistic rules instead.

Sounds like @nextcloud/prettier-config in the near future?

@susnux susnux marked this pull request as draft January 22, 2024 19:46
@susnux

This comment was marked as outdated.

@susnux susnux marked this pull request as ready for review January 22, 2024 21:09
…ss to 14.0.0

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@skjnldsv skjnldsv merged commit b426cdc into master Jan 23, 2024
6 checks passed
@skjnldsv skjnldsv deleted the chore/update-stylelint branch January 23, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants