Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LLDAP - Update ReadMe #4571

Merged
merged 6 commits into from
Apr 30, 2024
Merged

LLDAP - Update ReadMe #4571

merged 6 commits into from
Apr 30, 2024

Conversation

docjyJ
Copy link
Collaborator

@docjyJ docjyJ commented Apr 22, 2024 •
edited
Loading

See #4398

@docjyJ
Update readme.md
538d683 
Fix miss

Signed-off-by: Jean-Yves <7360784+docjyJ@users.noreply.github.com>
@docjyJ docjyJ added the documentation Improvements or additions to documentation label Apr 22, 2024
@docjyJ docjyJ changed the title Update readme.md (LLDAP LLDAP - Testing - fix mistake Apr 22, 2024
@docjyJ docjyJ marked this pull request as draft April 22, 2024 17:49
@docjyJ
Update readme.md
d5c754d 
Update default conf

Signed-off-by: Jean-Yves <7360784+docjyJ@users.noreply.github.com>
@docjyJ
Update readme.md
f32df3e 
Add admin default group

Signed-off-by: Jean-Yves <7360784+docjyJ@users.noreply.github.com>
@docjyJ
New doc
5fb3c9d 
Signed-off-by: Jean-Yves <7360784+docjyJ@users.noreply.github.com>
@docjyJ docjyJ added the 2. developing Work in progress label Apr 23, 2024
@szaimen szaimen mentioned this pull request Apr 24, 2024
Closed
21 tasks
@docjyJ
Update readme.md
bc259e4 
Signed-off-by: Jean-Yves <7360784+docjyJ@users.noreply.github.com>
@docjyJ
Update readme.md
2e964b9 
Signed-off-by: Jean-Yves <7360784+docjyJ@users.noreply.github.com>
@docjyJ
Copy link
Collaborator Author

docjyJ commented Apr 27, 2024

image
That seemed good to me. What do you think @szaimen?

@docjyJ docjyJ marked this pull request as ready for review April 27, 2024 11:29
@docjyJ docjyJ changed the title LLDAP - Testing - fix mistake LLDAP - Update docs Apr 27, 2024
@docjyJ docjyJ changed the title LLDAP - Update docs LLDAP - Update ReadMe Apr 27, 2024
@docjyJ docjyJ added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Apr 27, 2024
@docjyJ docjyJ requested a review from szaimen April 27, 2024 11:31
@docjyJ docjyJ self-assigned this Apr 27, 2024
@docjyJ docjyJ added this to the next milestone Apr 27, 2024
szaimen
szaimen approved these changes Apr 30, 2024
View reviewed changes
Copy link
Collaborator

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! :)

@szaimen szaimen merged commit 07a8367 into main Apr 30, 2024
3 checks passed
@szaimen szaimen deleted the docjyJ-patch-1 branch April 30, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szaimen szaimen szaimen approved these changes

Assignees

@docjyJ docjyJ

Labels
3. to review Waiting for reviews documentation Improvements or additions to documentation
Projects
None yet
Milestone
v8.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@docjyJ @szaimen