Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert Rich Documents Editor Web View to Kotlin #12158

Merged
merged 2 commits into from
Nov 13, 2023
Merged

Convert Rich Documents Editor Web View to Kotlin #12158

merged 2 commits into from
Nov 13, 2023

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Nov 13, 2023 •
edited
Loading

  • Tests written, or not not needed

@alperozturk96
Rename .java to .kt
124a56b 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
Convert to kt
b1a3b2f 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@github-actions GitHub Actions
Copy link

Codacy

Lint

TypemasterPR
Warnings7575
Errors00

SpotBugs

CategoryBaseNew
Bad practice2626
Correctness7171
Dodgy code364364
Experimental22
Internationalization99
Malicious code vulnerability22
Multithreaded correctness99
Performance5858
Security1818
Total559559

@github-actions GitHub Actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12158.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@AndyScherzinger AndyScherzinger merged commit 8e7bbb3 into master Nov 13, 2023
18 of 19 checks passed
@delete-merged-branch delete-merged-branch bot deleted the refactor/convert-RichDocumentsEditorWebView-to-kt branch November 13, 2023 12:30
@joshtrichards joshtrichards mentioned this pull request Jan 9, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

@ZetaTom ZetaTom Awaiting requested review from ZetaTom

@JonasMayerDev JonasMayerDev Awaiting requested review from JonasMayerDev

Assignees
No one assigned
Labels
3. to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alperozturk96 @AndyScherzinger