Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix collabora files not loading #12349

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

JonasMayerDev
Copy link
Collaborator

Allow loadUrl with extra_url = null to create new document viewer.
Opening a collabora file (eg. docx file) before was not possible (infinite loading screen).
Fixes #12338

  • Tests written, or not not needed

Signed-off-by: Jonas Mayer <jonas.a.mayer@gmx.net>
@JonasMayerDev JonasMayerDev linked an issue Jan 9, 2024 that may be closed by this pull request
4 tasks
Copy link

github-actions bot commented Jan 9, 2024

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12349.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@tobiasKaminsky
Copy link
Member

/backport to stable-3.27

Copy link

github-actions bot commented Jan 9, 2024

Codacy

Lint

TypemasterPR
Warnings6969
Errors33

SpotBugs

CategoryBaseNew
Bad practice2626
Correctness6969
Dodgy code353353
Experimental22
Internationalization99
Malicious code vulnerability22
Multithreaded correctness99
Performance5454
Security1818
Total542542

@alperozturk96 alperozturk96 merged commit a301062 into master Jan 9, 2024
22 checks passed
@delete-merged-branch delete-merged-branch bot deleted the 12338-collabora-not-loading-in-app-v3270 branch January 9, 2024 13:25
@connelhooley
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12349.apk qrcode To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

This link isn't working for me, is there a rough idea for when the app will be updated in the app store? Or is there anywhere else to get the APK? I'm just setting NextCloud up for the first time so just wanted to see it all working in the app. Thanks for your work fixing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collabora not loading existing documents in app v3.27.0
4 participants