Revert "Do not ignore ignoreEtags" #2330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
👍 |
AndyScherzinger
force-pushed
the
revert-2037-useIgnoreEtagAgain
branch
from
0b84d2e to
1d2ed0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we rely on eTag changes we do not get notified if a file is favorited/unfavorited.
It does not affect our server side serch, but our favorite icon would be outdated as long until the parent folder is changed and thus gets a new eTag.
A change on server side is discussed here, but will not be ready for our next version.
This needs to be in 3.1 as otherwise the behaviour is broken.