Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ktlint from 0.40.0 to 0.41.0 #8177

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 17, 2021

Bumps ktlint from 0.40.0 to 0.41.0.

Release notes

Sourced from ktlint's releases.

0.41.0

[0.41.0] - 2021-03-16

Note: This release contains breaking changes to globs passed to ktlint via the command line. See (#999) and the README.

Thank you to t-kameyama and paul-dingemans for your contributions to this release!

Added

  • New ktlint_ignore_back_ticked_identifier EditorConfig option for max-line-length rule to ignore long method names inside backticks (primarily used in tests) (#1007)
  • Allow to add/replace loaded .editorconfig values via ExperimentalParams#editorConfigOverride (#1016)
  • ReporterProvider, LintError, RuleSetProvider now implement Serializable interface

Fixed

  • Incorrect indentation with multiple interfaces (#1003)
  • Empty line before primary constructor is not reported and formatted-out (#1004)
  • Fix '.editorconfig' generation for "import-ordering" rule (#1011)
  • Fix "filename" rule will not work when '.editorconfig' file is not found (#997)
  • EditorConfig generation for import-ordering (#1011)
  • Internal error (no-unused-imports) (#996)
  • Fix false positive when argument list is after multiline dot-qualified expression (argument-list-wrapping) (#893)
  • Fix indentation for function types after a newline (indent) (#918)
  • Don't remove the equals sign for a default argument (no-line-break-before-assignment) (#1039)
  • Fix internal error in no-unused-imports (#1040)
  • Fix false positives when declaration has tail comments (spacing-between-declarations-with-comments) (#1053)
  • Fix false positive after else keyword (argument-list-wrapping) (#1047)
  • Fix formatting with comments (colon-spacing) (#1057)
  • Fix IndexOutOfBoundsException in argument-list-wrapping-rule formatting file with many corrections (#1081)
  • Fix formatting in arguments (multiline-if-else) (#1079)
  • Fix experimental:annotation-spacing-rule autocorrection with comments
  • Migrate from klob dependency and fix negated globs passed to CLI are no longer worked (#999) Breaking: absolute paths globs will no longer work, check updated README

Changed

  • Update Gradle shadow plugin to 6.1.0 version
  • Align with Kotlin plugin on how alias pattern is represented for imports layout rule (#753)
  • Align with Kotlin plugin on how subpackages are represented (#753)
  • Deprecated custom kotlin_imports_layout EditorConfig property. Please use ij_kotlin_imports_layout to ensure that the Kotlin IDE plugin and ktlint use same imports layout (#753)
  • Deprecated idea and ascii shortcuts as the ij_kotlin_imports_layout property does not support those. Please check README on how to achieve those with patterns (#753)
  • Update Gradle to 6.8.3 version
  • Update Kotlin to 1.4.31 version. Fixes #1063.
Changelog

Sourced from ktlint's changelog.

[0.41.0] - 2021-03-16

Note: This release contains breaking changes to globs passed to ktlint via the command line. See (#999) and the README.

Thank you to t-kameyama and paul-dingemans for your contributions to this release!

Added

  • New ktlint_ignore_back_ticked_identifier EditorConfig option for max-line-length rule to ignore long method names inside backticks (primarily used in tests) (#1007)
  • Allow to add/replace loaded .editorconfig values via ExperimentalParams#editorConfigOverride (#1016)
  • ReporterProvider, LintError, RuleSetProvider now implement Serializable interface

Fixed

  • Incorrect indentation with multiple interfaces (#1003)
  • Empty line before primary constructor is not reported and formatted-out (#1004)
  • Fix '.editorconfig' generation for "import-ordering" rule (#1011)
  • Fix "filename" rule will not work when '.editorconfig' file is not found (#997)
  • EditorConfig generation for import-ordering (#1011)
  • Internal error (no-unused-imports) (#996)
  • Fix false positive when argument list is after multiline dot-qualified expression (argument-list-wrapping) (#893)
  • Fix indentation for function types after a newline (indent) (#918)
  • Don't remove the equals sign for a default argument (no-line-break-before-assignment) (#1039)
  • Fix internal error in no-unused-imports (#1040)
  • Fix false positives when declaration has tail comments (spacing-between-declarations-with-comments) (#1053)
  • Fix false positive after else keyword (argument-list-wrapping) (#1047)
  • Fix formatting with comments (colon-spacing) (#1057)
  • Fix IndexOutOfBoundsException in argument-list-wrapping-rule formatting file with many corrections (#1081)
  • Fix formatting in arguments (multiline-if-else) (#1079)
  • Fix experimental:annotation-spacing-rule autocorrection with comments
  • Migrate from klob dependency and fix negated globs passed to CLI are no longer worked (#999) Breaking: absolute paths globs will no longer work, check updated README

Changed

  • Update Gradle shadow plugin to 6.1.0 version
  • Align with Kotlin plugin on how alias pattern is represented for imports layout rule (#753)
  • Align with Kotlin plugin on how subpackages are represented (#753)
  • Deprecated custom kotlin_imports_layout EditorConfig property. Please use ij_kotlin_imports_layout to ensure that the Kotlin IDE plugin and ktlint use same imports layout (#753)
  • Deprecated idea and ascii shortcuts as the ij_kotlin_imports_layout property does not support those. Please check README on how to achieve those with patterns (#753)
  • Update Gradle to 6.8.3 version
  • Update Kotlin to 1.4.31 version. Fixes #1063.
Commits
  • 0de86c8 prep CHANGELOG for 0.41.0 (#1109)
  • b6fa2c8 Merge pull request #1108 from Tapchicoma/tapchicoma/move-baseline-support
  • 1826101 Move baseline utils into 'ktlint-core' package.
  • 338a9a4 Merge pull request #1100 from Tapchicoma/tapchicoma/fix-npe
  • 44418ef Fix NPE in NoConsecutiveBlankLinesRule.
  • eecd43d Fix editorconfig property for max-line-length rule (#1098)
  • c206183 Merge pull request #1099 from Tapchicoma/tapchicoma/serializable
  • 8954d4c RuleSetProvider now implements Serializable interface.
  • da8c3f6 LintError now implements Serializable interface.
  • 8435fe3 ReporterProvider now implements Serializable interface.
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually

Bumps [ktlint](https://github.com/pinterest/ktlint) from 0.40.0 to 0.41.0.
- [Release notes](https://github.com/pinterest/ktlint/releases)
- [Changelog](https://github.com/pinterest/ktlint/blob/master/CHANGELOG.md)
- [Commits](pinterest/ktlint@0.40.0...0.41.0)

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added 3. to review dependencies Pull requests that update a dependency file labels Mar 17, 2021
@nextcloud-android-bot
Copy link
Collaborator

Codacy

Lint

TypemasterPR
Warnings232232
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings27
Correctness Warnings51
Internationalization Warnings9
Multithreaded correctness Warnings9
Performance Warnings73
Security Warnings40
Dodgy code Warnings98
Total307

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings27
Correctness Warnings51
Internationalization Warnings9
Multithreaded correctness Warnings9
Performance Warnings73
Security Warnings40
Dodgy code Warnings98
Total307

@codecov
Copy link

codecov bot commented Mar 17, 2021

Codecov Report

Merging #8177 (407054e) into master (99a4104) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #8177      +/-   ##
============================================
- Coverage     29.01%   28.96%   -0.05%     
  Complexity        5        5              
============================================
  Files           456      456              
  Lines         34968    34968              
  Branches       4883     4883              
============================================
- Hits          10146    10129      -17     
- Misses        23295    23315      +20     
+ Partials       1527     1524       -3     
Impacted Files Coverage Δ Complexity Δ
.../java/com/nextcloud/client/jobs/OfflineSyncWork.kt 9.25% <0.00%> (-38.89%) 0.00% <0.00%> (ø%)
...oud/android/operations/RefreshFolderOperation.java 75.62% <0.00%> (-1.44%) 0.00% <0.00%> (ø%)
...a/com/owncloud/android/utils/FileStorageUtils.java 50.00% <0.00%> (-1.17%) 0.00% <0.00%> (ø%)
...cloud/android/ui/activity/FileDisplayActivity.java 23.69% <0.00%> (+0.42%) 0.00% <0.00%> (ø%)
...owncloud/android/ui/adapter/OCFileListAdapter.java 39.93% <0.00%> (+0.48%) 0.00% <0.00%> (ø%)
...loud/android/datamodel/ThumbnailsCacheManager.java 38.53% <0.00%> (+0.53%) 0.00% <0.00%> (ø%)

@AndyScherzinger AndyScherzinger merged commit b78088b into master Mar 17, 2021
@delete-merged-branch delete-merged-branch bot deleted the dependabot/gradle/com.pinterest-ktlint-0.41.0 branch March 17, 2021 06:11
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.17.0 milestone Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KtLint fails to run on JDK 15
3 participants