Add banner notification type #773
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
…is added Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
…Options are missing Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
…abase id Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com> Signed-off-by: mwinkens <104770531+mwinkens@users.noreply.github.com>
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com> Signed-off-by: mwinkens <104770531+mwinkens@users.noreply.github.com>
Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
…the user config lazily Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
…anner Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
mwinkens
force-pushed
the
banner
branch
3 times, most recently
from
247c094 to
cc114d5
Compare
reset some phar changes in unchanged files, better commenting, fix a minor merge mistake Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature allows adding a banner as an announcement option. The user has to click it away in order to use the navbar again, because it's hidden behind it. Allows for multiple banners.
With #767 this also allows for a daily warning, for example: "Info: Today office is disabled due to a maintenance". This also allows to set this over the API endpoint (if you can verify as admin) in an automatic manner.
I might need some help with proper css here. This announcement works on every(!) page, where js is loaded and you are a logged in user. Doesn't show announcements to not-logged-in users
dark mode:
light mode:
based on #767 , therefore stays a draft until merged
related #147