-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CLI Commands #779
Add CLI Commands #779
Conversation
Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
…is added Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
…Options are missing Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
…abase id Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
@nickvergessen this is also ready for review and if you want we can integrate this into the next update! ~400 lines of this ~800 lines PR are just unit tests, so this shouldn't take too much effort. Also this PR doesn't have a frontend 🎉 |
@@ -28,6 +28,11 @@ | |||
<referencedClass name="Doctrine\DBAL\Types\Types" /> | |||
<referencedClass name="OC" /> | |||
<referencedClass name="OCA\Guests\UserBackend" /> | |||
<referencedClass name="Symfony\Component\Console\Command\Command" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a fan of this thirdparty access. Symfony version is not the same across all supported versions.
Also by ignoring it in psalm, CI will not detect if there is an issue. But yeah we don't have a better option atm.
Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com> Signed-off-by: mwinkens <104770531+mwinkens@users.noreply.github.com>
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com> Signed-off-by: mwinkens <104770531+mwinkens@users.noreply.github.com>
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com> Signed-off-by: mwinkens <104770531+mwinkens@users.noreply.github.com>
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com> Signed-off-by: mwinkens <104770531+mwinkens@users.noreply.github.com>
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com> Signed-off-by: mwinkens <104770531+mwinkens@users.noreply.github.com>
Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
@nickvergessen ready for review again 🎉 |
This allows to add announcements without a notification type, which the API allows, these notifications will still appear in the notification app listed Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com> Signed-off-by: mwinkens <104770531+mwinkens@users.noreply.github.com>
Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
Really nice! Thanks @nickvergessen and @mwinkens \o/ |
This PR adds CLI commands for announcing, deleting and viewing announcements:
Help:
CLICK ME
Announce:
List
Delete
Examples:
CLICK ME
Announce:
Minimal
Minimal, you need at least one announcement option:
Announces as user nextcloud27 a message ('a test message') with a subject ('a test').
Default group is
everyone
, so this announcement reaches everyone. However this didn't use any notification type, like--emails
and is just visible in the announcement appGroups
You can specify multiple groups with
--group
or-g
:This example only announces to users with group
group1
andgroup2
and sends each user in the group an emailScheduling/Deletion
You can set the scheduled announcement time with
--schedule-time <time>
, while the time can be a unix timestamp or any string that can be interpreted by strtotimeUnix-timestamp:
String:
Tomorrow:
Friday:
16:45
delete-time is similar
List
You can specify the output limit, default is 10:
Delete
Delete announcement with ID 33:
Roadmap
based on #767 (merged)
closes #147