Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move scheduling and deletion into ... menu #847

Merged
merged 6 commits into from
Sep 30, 2024

Conversation

mwinkens
Copy link
Contributor

@mwinkens mwinkens commented Sep 24, 2024

closes #820
closes #846 (for some reason)

This was the best I was able to come up with for now. I think it's not too bad with the separators.
@nickvergessen I don't know how to handle the translations, I would remove the (optional) part here.

Bildschirmfoto vom 2024-09-24 15-14-12

Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
@nickvergessen
Copy link
Member

I don't know how to handle the translations, I would remove the (optional) part here.

Sounds good

mwinkens and others added 5 commits September 24, 2024 15:13
Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
Signed-off-by: Marvin Winkens <m.winkens@fz-juelich.de>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Copy link
Member

I can't get rid of that "Please choose a date" text, I updated the screenshot in the description

Managed to do that

@nickvergessen
Copy link
Member

you need to select the hours or this component doesn't default to 0:00, which feels un-intuitive

Seems to only be a problem with Firefox, Chrome shows a time picker next to it and automatically sets the current time:

Firefox Chrome
grafik grafik

@nickvergessen nickvergessen merged commit f96632f into nextcloud:main Sep 30, 2024
39 checks passed
@JGHobbyist
Copy link

This is such a great idea... However when setting a scheduled announcement, I pick the date and time and get the following error... This then doesn't send the announcement out at all (by email or notification) but only keeps it in the center... Is there something that I need to configure that I may have missed?

Thank you for all the work you do in making Nextcloud better!
Test Schedule Announcement Before

Test Schedule Announcement After

@nickvergessen
Copy link
Member

Fixed already, just waiting for a release

@JGHobbyist
Copy link

That's fantastic, Thank you. I asked because the announcement didn't get sent at all when the schedule option was used. So I guess the next release this will send the scheduled announcement?

"just waiting for a release" - as in you're waiting for the next NC update release or you're waiting for the next Announcement center release to group the fixes together?

Thanks again.

@nickvergessen
Copy link
Member

The later

@mwinkens
Copy link
Contributor Author

mwinkens commented Oct 3, 2024

@JGHobbyist The emails and notifications should be send at the schedule time (opposed to immediately), but you may need to configure it at the ... menu. The invalid date bug is only visual, therefore the rest should still work.

@mwinkens mwinkens deleted the scheduler-actions branch October 3, 2024 21:04
@nickvergessen
Copy link
Member

Released 7.0.1 btw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vue runtime warning Move scheduling and deletion to menu
3 participants