Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README documentation out of date #5478

Closed
privatemaker opened this issue Sep 18, 2023 · 1 comment · Fixed by #5482
Closed

README documentation out of date #5478

privatemaker opened this issue Sep 18, 2023 · 1 comment · Fixed by #5482
Labels
1. to develop Accepted and waiting to be taken care of bug

Comments

@privatemaker
Copy link
Contributor

privatemaker commented Sep 18, 2023

Steps to reproduce

  1. Read the README.md
  2. Clone the repo
  3. Run the command make

Expected behavior

As a new contributor to Calendar, I want to easily following instructions in the README.md file of how to start developing.

Currently, I am stuck on the first step of Build the app documentation, as the make command does not complete successfully.

Actual behaviour

After many steps make seems to complete correctly, but the make command ends with an error about about a missing phpunit.xml file.

Calendar app version

3be6085

CalDAV-clients used

No response

Browser

No response

Client operating system

No response

Server operating system

Debian 12

Nextcloud version

28

Updated from an older installed version or fresh install

fresh install

Web server error log

...

Test Suites: 60 passed, 60 total
Tests:       356 passed, 356 total
Snapshots:   25 passed, 25 total
Time:        63.094 s
Ran all test suites.
phpunit -c phpunit.xml
Could not read "phpunit.xml".
make: *** [Makefile:43: test-php] Error 1


### Log file

_No response_

### Browser log

_No response_

### Additional info

Console error log

...

Test Suites: 60 passed, 60 total
Tests: 356 passed, 356 total
Snapshots: 25 passed, 25 total
Time: 63.094 s
Ran all test suites.
phpunit -c phpunit.xml
Could not read "phpunit.xml".
make: *** [Makefile:43: test-php] Error 1


**Observations and debugging**

- Using the 2 year old `phpunit.unit.xml` fails with errors
- Running `composer run test` seems to complete successfully
@privatemaker privatemaker added bug 0. to triage Pending approval or rejection labels Sep 18, 2023
@ChristophWurst ChristophWurst added 1. to develop Accepted and waiting to be taken care of and removed 0. to triage Pending approval or rejection labels Sep 18, 2023
@ChristophWurst
Copy link
Member

See nextcloud/twofactor_totp#1149 as a reference. The makefile is mostly obsolete. We can recommend npm i, composer i and npm run build (or dev)

privatemaker added a commit to privatemaker/calendar that referenced this issue Sep 19, 2023
Signed-off-by: Private Maker <privatemaker@posteo.net>
privatemaker added a commit to privatemaker/calendar that referenced this issue Sep 21, 2023
Signed-off-by: Private Maker <privatemaker@posteo.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants