Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hide sidepanel on print view #279

Merged
merged 1 commit into from
Jan 13, 2017
Merged

hide sidepanel on print view #279

merged 1 commit into from
Jan 13, 2017

Conversation

tcitworld
Copy link
Member

Hides the sidebar on print view.

We also could consider bundling https://github.com/fullcalendar/fullcalendar/blob/master/src/common/print.css

@tcitworld tcitworld added 3. to review Waiting for reviews design Related to design, interface, interaction design, UX, etc. labels Jan 5, 2017
@tcitworld
Copy link
Member Author

We should also change the title of the window to match the current view so that it's printed on the headers : #280

@georgehrke
Copy link
Member

The PR is working as described in the PR. But you won't be able to see which color belongs to which calendar.
This is definitely better then the current solution, but we need a proper print styles in the long run.
I will create an issue.

@georgehrke georgehrke merged commit 7b8ba34 into master Jan 13, 2017
@georgehrke georgehrke deleted the print-styles branch January 13, 2017 21:16
@georgehrke
Copy link
Member

there already is: #136

@alexanderdd
Copy link

@georgehrke hmm, left panel is not hidden for me in print view in NC 18.0.6 calendar 2.0.3 firefox 79.0
also the calendars in the sidebar have no colors next to them so you dont know which calendar belongs to which events

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews design Related to design, interface, interaction design, UX, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants