Accept and decline invitations

[st3iny]

Fixes #144

According to https://icalendar.org/CalDAV-Scheduling-RFC-6638/b-3-example-attendee-replying-to-an-invitation.html responding to an invitation is done by setting the participation status and sending the modified ics data to the server. Thunderbird seems to do the same thing.

The local participation status in the invitees list is updated right away (without reloading the page). There is one minor side effect: The accept/decline buttons internally trigger a full save which also persists changes of e.g. reminders. Fixing this would need a lot of potentially ugly code. Again, Thunderbird also ignores this case and other changes to the event are also saved upon accepting or declining.

Simple	Sidebar

Accept using the sidebar editor

Decline using the simple editor

TODO

• Fix red CI

[codecov]

Codecov Report

Merging #3864 (fae3fc5) into main (d771339) will decrease coverage by 0.25%.
The diff coverage is 0.00%.

❗ Current head fae3fc5 differs from pull request most recent head 58c4df7. Consider uploading reports for the commit 58c4df7 to get more accurate results

@@             Coverage Diff              @@
##               main    #3864      +/-   ##
============================================
- Coverage     29.61%   29.36%   -0.26%     
+ Complexity      322      318       -4     
============================================
  Files           220      220              
  Lines          7529     7455      -74     
  Branches        993      925      -68     
============================================
- Hits           2230     2189      -41     
+ Misses         5299     5266      -33     

Flag	Coverage Δ
javascript	20.55% <0.00%> (-0.43%)	⬇️
php	67.86% <ø> (+0.51%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...rc/components/Editor/InvitationResponseButtons.vue	0.00% <0.00%> (ø)
src/mixins/EditorMixin.js	0.00% <0.00%> (ø)
src/views/EditSidebar.vue	0.00% <0.00%> (ø)
src/views/EditSimple.vue	0.00% <0.00%> (ø)
src/fullcalendar/rendering/eventDidMount.js	27.45% <0.00%> (-0.62%)	⬇️
src/filters/recurrenceRuleFormat.js	82.00% <0.00%> (-0.53%)	⬇️
...dar/lib/Controller/AppointmentConfigController.php	76.34% <0.00%> (-0.26%)	⬇️
...xtcloud/apps/calendar/lib/Db/AppointmentConfig.php	46.34% <0.00%> (-0.18%)	⬇️
src/models/alarm.js	100.00% <0.00%> (ø)
src/models/event.js	100.00% <0.00%> (ø)
... and 37 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d771339...58c4df7. Read the comment docs.

[tcitworld]

This makes me notice we don't have any visual feedback in the calendar grid for when an event invitation is rejected?

[st3iny]

This makes me notice we don't have any visual feedback in the calendar grid for when an event invitation is rejected?

Indeed. This would be a nice followup.

[miaulalala]

I like it, but I dislike the button colours. Is there any way to make them fit in with them theming? Or maybe ask the design team for some input?

[GretaD]

I like it, but I dislike the button colours. Is there any way to make them fit in with them theming? Or maybe ask the design team for some input?

the accept one is a primary button so its the same as the colour of the theme(see also his example is green as the theme one), the decline is the error one that we use everywhere. So if we change it here, should be changed everywhere.

[miaulalala]

I like it, but I dislike the button colours. Is there any way to make them fit in with them theming? Or maybe ask the design team for some input?

the accept one is a primary button so its the same as the colour of the theme(see also his example is green as the theme one), the decline is the error one that we use everywhere. So if we change it here, should be changed everywhere.

Ah, I didn't realise it's the same colour as the theme :)

[GretaD]

code looks good but i cannot test it

[ChristophWurst]

with a custom theme color the accept button looks a bit strange :)

[ChristophWurst]

Works as expected. UX and design can be improved :)

[st3iny]

The button that corresponds to the current participation status is automatically hidden. E.g., the accept button will be hidden if I already accepted earlier.

[tcitworld]

The button that corresponds to the current participation status is automatically hidden. E.g., the accept button will be hidden if I already accepted earlier.

Maybe we can just disable it and update the label (accept -> accepted) instead?

[st3iny]

The button that corresponds to the current participation status is automatically hidden. E.g., the accept button will be hidden if I already accepted earlier.

Maybe we can just disable it and update the label (accept -> accepted) instead?

This should be discussed in the next design review. I'll add it to the list.