Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make confirm configurable for DatePicker #4407

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

newhinton
Copy link
Contributor

This alleviates the regression introduced by #2936

Signed-off-by: Felix Nüsse felix.nuesse@t-online.de

… overrides

Signed-off-by: Felix Nüsse <felix.nuesse@t-online.de>
@codecov
Copy link

codecov bot commented Aug 2, 2022

Codecov Report

Merging #4407 (07a8a1c) into main (0e4f2bd) will decrease coverage by 0.29%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #4407      +/-   ##
============================================
- Coverage     29.72%   29.42%   -0.30%     
  Complexity      330      330              
============================================
  Files           220      220              
  Lines          7611     7702      +91     
  Branches       1004     1019      +15     
============================================
+ Hits           2262     2266       +4     
- Misses         5349     5436      +87     
Flag Coverage Δ
javascript 20.51% <ø> (-0.27%) ⬇️
php 68.80% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...NavigationHeader/AppNavigationHeaderDatePicker.vue 0.00% <ø> (ø)
src/components/Shared/DatePicker.vue 0.00% <ø> (ø)
src/models/event.js 57.40% <0.00%> (-42.60%) ⬇️
src/views/Calendar.vue 0.00% <0.00%> (ø)
src/views/Dashboard.vue 0.00% <0.00%> (ø)
src/views/EditSimple.vue 0.00% <0.00%> (ø)
src/mixins/EditorMixin.js 0.00% <0.00%> (ø)
src/views/EditSidebar.vue 0.00% <0.00%> (ø)
src/store/calendarObjectInstance.js 0.00% <0.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e4f2bd...07a8a1c. Read the comment docs.

@szaimen szaimen added 3. to review Waiting for reviews bug regression Regression of a previous working feature labels Aug 12, 2022
@miaulalala
Copy link
Contributor

Hi, thanks for you PR! We're currently switching to native for datetime pickers - not sure if we need this then or if we might backport it. @JuliaKirschenheuter

@szaimen szaimen requested review from st3iny and removed request for st3iny October 5, 2022 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug regression Regression of a previous working feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants