Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Calendar Widget Data #4969

Closed
wants to merge 7 commits into from
Closed

Conversation

miaulalala
Copy link
Contributor

@miaulalala miaulalala commented Feb 8, 2023

Needs nextcloud/server#36620

Resolved part of #4813

Signed-off-by: Anna Larch anna@nextcloud.com

Signed-off-by: Anna Larch <anna@nextcloud.com>
@miaulalala miaulalala self-assigned this Feb 8, 2023
@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Base: 22.28% // Head: 13.70% // Decreases project coverage by -8.58% ⚠️

Coverage data is based on head (72b8daf) compared to base (fc01bfd).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4969      +/-   ##
============================================
- Coverage     22.28%   13.70%   -8.58%     
============================================
  Files           227      198      -29     
  Lines         10797     9424    -1373     
  Branches       2045     2132      +87     
============================================
- Hits           2406     1292    -1114     
+ Misses         8391     8132     -259     
Flag Coverage Δ
javascript 13.70% <0.00%> (-0.52%) ⬇️
php ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/views/Dashboard.vue 0.00% <0.00%> (ø)
src/store/settings.js 88.49% <0.00%> (-5.80%) ⬇️
src/models/event.js 57.14% <0.00%> (-0.27%) ⬇️
src/dashboard.js 0.00% <0.00%> (ø)
src/views/Calendar.vue 0.00% <0.00%> (ø)
src/views/EditSidebar.vue 0.00% <0.00%> (ø)
src/store/calendarObjectInstance.js 0.00% <0.00%> (ø)
src/components/AppNavigation/Settings.vue 0.00% <0.00%> (ø)
...apps/calendar/lib/Controller/BookingController.php
... and 36 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Copy link
Member

@tcitworld tcitworld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the time formatting is now done on the backend's side, we should format datetime using the user's own timezone setting, which might not be the same as the calendar's timezone or event the calendar object start or end time timezone.

lib/Dashboard/CalendarWidget.php Outdated Show resolved Hide resolved
lib/Dashboard/CalendarWidget.php Outdated Show resolved Hide resolved
@miaulalala
Copy link
Contributor Author

Superceded by #5417

@miaulalala miaulalala closed this Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants