-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Write Talk URL into location, not description #5395
feat: Write Talk URL into location, not description #5395
Conversation
Fall back to description if location is filled, e.g. for a hybrid event. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #5395 +/- ##
============================================
- Coverage 22.67% 22.66% -0.02%
Complexity 372 372
============================================
Files 237 237
Lines 11719 11725 +6
Branches 2278 2282 +4
============================================
Hits 2657 2657
- Misses 9062 9068 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Very nice 👍 I would like to suggest adding a bit of explanation before the link in the description. Example Teams: (Screenshot is from the imip email but the same text is used for the description ics field) Example Google: (Screenshot is also from the imip email but the same text is used for the description ics field) As backup, the link could always be in the description. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works 👍
Left two remarks about the general concept.
Generating text is fun and games until you have more than one language involved 😃 |
Klicken Sie auf den nachfolgenden Link, um an der Online-Video-Besprechung mit nächster Wolkenverbreitung teilzunehmen ;) |
Fall back to description if location is filled, e.g. for a hybrid event.
This contributes part 2 of #5389.
How to test
On
main
there will be an URL inserted into the description.On this branch the URL will be written to the location if it's empty or not set. If it is, the URL is appended to the description.