Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert unecessary refactoring of getDisplayName() #5518

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Conversation

hamza221
Copy link
Contributor

@hamza221 hamza221 commented Oct 6, 2023

continuation of #5517

@hamza221 hamza221 added 3. to review Waiting for reviews performance 🚀 labels Oct 6, 2023
@hamza221 hamza221 requested a review from st3iny October 6, 2023 12:49
@hamza221 hamza221 self-assigned this Oct 6, 2023
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (732bf1a) 22.28% compared to head (8bbf4d2) 22.26%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5518      +/-   ##
============================================
- Coverage     22.28%   22.26%   -0.02%     
  Complexity      388      388              
============================================
  Files           240      240              
  Lines         11793    11789       -4     
  Branches       2301     2301              
============================================
- Hits           2628     2625       -3     
+ Misses         9165     9164       -1     
Flag Coverage Δ
javascript 13.82% <ø> (ø)
php 63.27% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lib/Service/Appointments/MailService.php Outdated Show resolved Hide resolved
Signed-off-by: hamza221 <hamzamahjoubi221@gmail.com>
@st3iny st3iny merged commit c5c3d62 into main Oct 18, 2023
39 of 40 checks passed
@st3iny st3iny deleted the enh/getDisplayName branch October 18, 2023 10:36
@st3iny st3iny added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish performance 🚀
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants