Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps): bump @nextcloud/dialogs from 4.2.1 to v5 (main) #5525

Closed
wants to merge 1 commit into from
Closed

fix(deps): bump @nextcloud/dialogs from 4.2.1 to v5 (main) #5525

wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Oct 11, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@nextcloud/dialogs ^4.2.1 -> ^5.0.0-beta.5 age adoption passing confidence

Release Notes

nextcloud-libraries/nextcloud-dialogs (@​nextcloud/dialogs)

v5.0.0-beta.5

Compare Source

Full Changelog

🐛 Fixed bugs
🤖 Dependency updates

v5.0.0-beta.4

Compare Source

Full Changelog

🐛 Fixed bugs

v5.0.0-beta.3

Compare Source

Full Changelog

🐛 Fixed bugs
🚀 Enhancement
🤖 Dependency updates

v5.0.0-beta.2

Compare Source

Full Changelog

🚀 Enhancement
  • feat: Add icons for filepicker and allow reactive button based on current path and selection #​938 (susnux)
  • feat(FilePicker): Always show file extension as a trailing text part #​931 (susnux)
  • Add empty content when there are no files #​930 (susnux)
🐛 Fixed bugs
  • fix: The file list should be showed when files are loading #​937 (susnux)
  • fix(FilePicker): Ensure focus-visible outline is visible for all focusable elements #​935 (susnux)
  • fix(FilePicker): Do not show checkboxes on single select mode #​929 (susnux)
  • fix: Add missing defaults to DialogButton #​927 (susnux)
  • fix(FilePickerBuilder): Revert API change on pick() #​925 (susnux)
  • fix(FilePicker): The table height should be max. 100% #​921 (susnux)
Changed

v5.0.0-beta.1

Compare Source

💥 Breaking
  • A Vue based file picker is provided which uses @nextcloud/vue version 8, so this library will only work on Nextcloud 28+
  • Modernize FilePickerBuilder to directly make use of the Vue based file picker #​904 (@​susnux)
    • This slightly breaks the FilePickerBuilder API:
      • FilePicker.pick now returns a Promise resolving to string[] containing the picked paths
      • FilePicker.constructor parameter order was changed
      • FilePickerBuilder.setModal was removed as it has no effect
      • FilePickerBuilder.setType is deprecated in favor of FilePickerBuilder.addButton
      • FilePickerBuilder.addButton was added which allows to add custom buttons with callbacks on click (so users can now distinguish which button was clicked)
🚀 Enhancement
  • A Vue based FilePicker component was added, which can be used either as a component or using programmatically #​878 (@​susnux)
  • FilePickerBuilder: Allow to add custom buttons #​896 (@​susnux)
🐛 Fixed bugs
Changed
  • The package does no longer contain core-js polyfills as Nextcloud core already provides polyfills #​863 (@​susnux)
  • The project was moved to a new Github organization (nextcloud-libraries)
  • Add version compatibility section to README #​891 (@​susnux)
  • Improved developer documentation #​906 (@​susnux)
  • Dependency updates

Configuration

📅 Schedule: Branch creation - "before 5am on wednesday" in timezone Europe/Vienna, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate
fix(deps): bump @nextcloud/dialogs from 4.2.1 to v5
b991665 
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate renovate bot added 3. to review Waiting for reviews dependencies Pull requests that update a dependency file labels Oct 11, 2023
@renovate renovate bot requested review from GretaD and st3iny October 11, 2023 00:49
@codecov
Copy link

codecov bot commented Oct 11, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (732bf1a) 22.28% compared to head (b991665) 22.28%.
Report is 11 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##               main    #5525   +/-   ##
=========================================
  Coverage     22.28%   22.28%           
  Complexity      388      388           
=========================================
  Files           240      240           
  Lines         11793    11793           
  Branches       2301     2301           
=========================================
  Hits           2628     2628           
  Misses         9165     9165
Flag Coverage Δ
javascript 13.82% <ø> (ø)
php 63.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@st3iny
Copy link
Member

st3iny commented Oct 11, 2023

It seems like the most recent beta release was published to the latest tag. We should test this one as it includes a lot of (potentially breaking) changes.

@tcitworld
Copy link
Member

A Vue based file picker is provided which uses @nextcloud/vue version 8, so this library will only work on Nextcloud 28+

So closing straight away.

@tcitworld tcitworld closed this Oct 11, 2023
@renovate
Copy link
Contributor Author

renovate bot commented Oct 11, 2023 •
edited
Loading

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future 5.x releases. But if you manually upgrade to 5.x then Renovate will re-enable minor and patch updates automatically.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

@renovate renovate bot deleted the renovate/main-nextcloud-dialogs-5.x branch October 11, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GretaD GretaD Awaiting requested review from GretaD

@st3iny st3iny Awaiting requested review from st3iny st3iny is a code owner

Assignees
No one assigned
Labels
3. to review Waiting for reviews dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@st3iny @tcitworld