Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CalendarObjectInstance: reset attendee participation status on duplication of an event #6302

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

GVodyanov
Copy link
Contributor

Fix #5793

That eventComponent is black magic...

@GVodyanov GVodyanov added the 3. to review Waiting for reviews label Aug 29, 2024
@GVodyanov GVodyanov self-assigned this Aug 29, 2024
@GVodyanov GVodyanov force-pushed the fix/reset-participation-status-on-duplication branch 2 times, most recently from 0a15605 to 32ba28e Compare August 29, 2024 10:50
…uplication of an event

Signed-off-by: Grigory Vodyanov <scratchx@gmx.com>
@GVodyanov GVodyanov force-pushed the fix/reset-participation-status-on-duplication branch from 32ba28e to 0b7f8dc Compare August 29, 2024 10:54
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 23.75%. Comparing base (cbfbda2) to head (0b7f8dc).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
src/models/event.js 25.00% 2 Missing and 1 partial ⚠️
src/store/calendarObjectInstance.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6302      +/-   ##
============================================
- Coverage     23.76%   23.75%   -0.01%     
  Complexity      454      454              
============================================
  Files           246      246              
  Lines         11715    11718       +3     
  Branches       2207     2220      +13     
============================================
  Hits           2784     2784              
- Misses         8614     8615       +1     
- Partials        317      319       +2     
Flag Coverage Δ
javascript 15.35% <20.00%> (-0.01%) ⬇️
php 59.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GVodyanov GVodyanov merged commit 38b658d into main Aug 29, 2024
34 of 35 checks passed
@GVodyanov GVodyanov deleted the fix/reset-participation-status-on-duplication branch August 29, 2024 11:15
@ChristophWurst
Copy link
Member

can we haz backport?

@GVodyanov
Copy link
Contributor Author

/backport to stable5.0

@backportbot backportbot bot added the backport-request A backport was requested for this pull request label Sep 2, 2024
@backportbot backportbot bot removed the backport-request A backport was requested for this pull request label Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicating an event with attendees should reset attendence status and RSVP
3 participants