fix duplicate name on fedcircle #1744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArtificialOwl
force-pushed
the
fix/noid/fix-duplicate-federated-circles
branch
3 times, most recently
from
ca76ac0 to
40c68a2
Compare
come-nc
reviewed
Nov 7, 2024
| use OCP\Migration\SimpleMigrationStep; | ||
| use Psr\Log\LoggerInterface; | ||
|
|
||
| class Version0031Date20241105133904 extends SimpleMigrationStep { |
ArtificialOwl
commented
Nov 21, 2024
|
|
||
| try { | ||
| $table = $schema->getTable('circles_mountpoint'); | ||
| if (!$table->hasIndex('dname')) { |
There was a problem hiding this comment.
name should be 'mp_sid_hash'
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
ArtificialOwl
force-pushed
the
fix/noid/fix-duplicate-federated-circles
branch
from
40c68a2 to
6cddb36
Compare
mejo-
approved these changes
Nov 27, 2024
|
/backport to stable30 |
|
/backport to stable29 |
2 tasks
|
/backport to stable28 |
This was referenced Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix issues when sharing file on federated circles:
Files_Sharing/External/Manager